299226 - Can't type opt-keystrokes in inputs/textareas

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Starting with the nightly from the 20050628, I can't type any opt-single_key
characters (c-cedilla, tm, etc.) in inputs/textareas (US keylayout, 10.3.9). 
Composed characters (opt-accent-letter) still work.  Opt-single_key chars do
work in Cocoa fields like search and location bar.

The 28th's DeerPark does not have this problem.

Since the 28th is the first day that changes started appearing since the 23rd,
it could be a lot of things, but bug 298111 did mess with form widgets :-)

There were a couple of trunk checkins dealing with unicode characters in that
timeframe, though:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=Camino&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=20050623+11%3A15%3A00&maxdate=20050628+18%3A00%3A00&cvsroot=%2Fcvsroot

Comment 1

[Mike Pinkerton (not reading bugmail)]

maybe we need to fix something in cocoa widget to accompany that change?

Comment 2

[Simon Fraser [no longer active]]

Maybe this was my changes in bug 179308.

Comment 3

[Simon Fraser [no longer active]]

What caused this is that I'm now setting geckoEvent.isAlt on the KEY_PRESS event
sent in -insertText:

Comment 4

[Simon Fraser [no longer active]]

Attachment: Patch to not set modifiers in gecko event in insertText:

This patch undoes some changes I made for no good reason in bug 179308.

Comment 5

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 187830 [details] [diff] [review]
Patch to not set modifiers in gecko event in insertText:

r=pink

Comment 6

[Simon Fraser [no longer active]]

Checked in.

Comment 7

[Wevah (Nate Weaver)]

*** Bug 299288 has been marked as a duplicate of this bug. ***