Closed Bug 299228 Opened 19 years ago Closed 18 years ago

nsIBiDiKeyboard cocoa implementation

Categories

(Core :: Widget: Cocoa, defect, P2)

Product:
Core
Component:
Widget: Cocoa
Platform:
PowerPC
macOS
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9alpha8

People

(Reporter: asaf, Assigned: jaas)

Details

Attachments

(1 file)

fix v1.0
6.38 KB, patch
asaf
: review+
mikepinkerton
: superreview+
Details | Diff | Splinter Review
Status: NEW → ASSIGNED
Priority: -- → P2
Target Milestone: --- → mozilla1.9beta
Blocks: cocoa
Asaf - this bug is currently listed as a requirement for turning on Cocoa widgets on the trunk. Any idea when you'll get to it?
Early next week, apparently.
Component: Widget: Mac → Widget: Cocoa
QA Contact: mac → cocoa
Priority: P2 → P1
Target Milestone: mozilla1.9beta → mozilla1.9alpha
No longer blocks: cocoa
Priority: P1 → P2
Target Milestone: mozilla1.9alpha → mozilla1.9beta
Assignee: mano → joshmoz
Status: ASSIGNED → NEW
Attached patch fix v1.0 — — Splinter Review 
This just moves bidi from mac to cocoa with some code cleanup. Seems like we don't even want to actually rewrite this in cocoa, but I have changed it to .mm so we have the option to use cocoa in the future. We can open other bugs if we want to add to this impl or something like that.
Attachment #244072 - Flags: review?
Attachment #244072 - Flags: review? → review?(mano)
Comment on attachment 244072 [details] [diff] [review]
fix v1.0

So, I was looking for the cocoa wrappers for some time now (I could swear I had seen them at the time I wrote this code!) but didn't find anything so far...

r=mano for copying it over, the code itself has been reviewed by javier, fyi.
Attachment #244072 - Flags: review?(mano) → review+
Attachment #244072 - Flags: superreview?(mikepinkerton)
Comment on attachment 244072 [details] [diff] [review]
fix v1.0

sr=pink
Attachment #244072 - Flags: superreview?(mikepinkerton) → superreview+
landed on trunk
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: