299237 - Mozilla build breaks on Solaris with pkg-config >= 0.17.1

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Matt Keenan]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20050214
Build Identifier: Mozilla 1.7

Recent version of pkg-config no longer include all dependent libraries
when printing --libs.  (See
http://www.advogato.org/person/jamesh/diary.html?start=192
for details.)  On Solaris, binaries that directly use APIs from library L
now need to link to L explicitely, even if they link to another library M
that links to L.

Any source using libIDL-2 will also need glib-2.0, same for gtk+2.0 will
also need glib-2.0.


Reproducible: Always

Steps to Reproduce:
1. On Solaris, install pkgbuild-0.17.2
2. Try building mozilla-1.7

Actual Results:  
The build breaks with unresolved symbols trying to build 
  xpcom/typelib/xpidl/xpidl_idl.c 

The unresolved symbols all come from glib-2.0, -lglib-2.0 is not included
in the compile line, should be.

Expected Results:  
Should Build :(

Comment 1

[Matt Keenan]

Attachment: Patch to configure to add extra libs for compile with new pkg-config

Comment 2

[Matt Keenan]

Attachment: Update patch with some more libs... :)

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Same thing, merge to trunk

I took out the configure changes, since that's autogenerated from configure.in anyway.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

are all those gobject-2.0 dependencies really needed?

Comment 5

[Boris Zbarsky [:bzbarsky]]

Fixed on trunk.