299250 - Margin-left not correctly set on xul:hbox within rtl div

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Martijn Wargers (dead)]

See upcoming testcase.

With the testcase I get a scrollbar for the regular div (the top one).
But I don't get a scrollbar for the rtl div (the bottom one).
I think I should be getting one, there also.
It seems like margin-left is completely ignored in the testcase.

Comment 1

[Martijn Wargers (dead)]

Attachment: testcase

Comment 2

[Uri Bernstein]

Confirmed on OS X => All/All

Comment 3

[Boris Zbarsky [:bzbarsky]]

Sounds like a xul box model issue, actually...

Comment 4

[Uri Bernstein]

Starting from the 2005-12-16-05 trunk nightly, I'm not seeing an (active) scrollbar on either of the divs (and therefore I can't see the text in either of them). I don't know XUL, so I can't say if this is a regression or a fix.

Regarding "It seems like margin-left is completely ignored in the testcase." - isn't that a duplicate of bug 121633?

Comment 5

[Martijn Wargers (dead)]

Maybe the behavior changed because of the fix for bug 307992?
I guess the original issue is indeed related to/a duplicate of bug 121633.

Comment 6

[Boris Zbarsky [:bzbarsky]]

I don't really know how the XUL stuff's supposed to work either.  In fact, I doubt anyone does.  ;)

For this bug, I think we should just revisit it once bug 121633 is fixed.

Comment 7

[Martijn Wargers (dead)]

Well, the testcase won't work again with this changed behavior, so if this behavior would stay, I would need to make an updated testcase.
But I think what current trunk builds are doing is wrong. I filed bug 328240 for it. (and even if xul layout is undefined, I still would prefer the old behavior)

Comment 8

[Martijn Wargers (dead)]

I can see another regression now with the testcase for this bug, see bug 331594.

Comment 9

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20061208 Minefield/3.0a1 ID:2006120812 [cairo]

Seems fixed by reflow branch landing

both scrollbars visable

Comment 10

[Martijn Wargers (dead)]

Yeah, fixed by the reflow branch landing.
It was a problem in the 2006-12-06 build, but not anymore in the 2006-12-08 build.

Comment 11

[Boris Zbarsky [:bzbarsky]]

Please add bugs fixed by reflow branch to the dep list...

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Adding in-testsuite? nomination per bz's request in m.d.t.l. Sorry for the bugspam.

Comment 13

[(no longer active)]

Mass-assigning the new rtl keyword to RTL-related (see bug 349193).