299272 - richlistbox assumes each richlistitem has a fireEvent method

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Doron Rosenberg (IBM)]

Comment 1

[Doron Rosenberg (IBM)]

Attachment: Add richlistitem to xul.css and give it some default styling.

Comment 2

[Doron Rosenberg (IBM)]

Attachment: use instanceof rather than nodeTypes/localnames

Comment 3

[Robert Strong (they/them - no direct email)]

+richlistbox {
+  background-color:white;
+}
nit: shouldn't that be a system color (e.g. "Window" instead of "white")?

Comment 4

[Doron Rosenberg (IBM)]

Attachment: provide default color/bgcolors for all themes

Comment 5

[Benjamin Smedberg]

Comment on attachment 188341 [details] [diff] [review]
provide default color/bgcolors for all themes

The richlistitem * selector will kill performance.

Comment 6

[Doron Rosenberg (IBM)]

Attachment: remove perf issue

Added the css styles that were removed to
http://developer-test.mozilla.org/en/docs/XUL:Richlistbox, which is a work in
progress.

Comment 7

[Benjamin Smedberg]

Comment on attachment 188349 [details] [diff] [review]
remove perf issue

I still dislike the "fireEvent" method name, but that's something to fix later
I suppose.

Comment 8

[Doron Rosenberg (IBM)]

(In reply to comment #7)
> (From update of attachment 188349 [details] [diff] [review] [edit])
> I still dislike the "fireEvent" method name, but that's something to fix later
> I suppose.
> 

The name comes from the previous widget (richview), and it was left to reduce
changes to existing code.

Comment 9

[Doron Rosenberg (IBM)]

fixed, thanks for catching the perf issue.