Closed Bug 299283 Opened 19 years ago Closed 19 years ago

Fix bug in GetInstanceNodeForData

Categories

(Core Graveyard :: XForms, defect)

Product:
Core Graveyard
Component:
XForms
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: aaronr, Assigned: aaronr)

References

Details

Attachments

(2 files)

testcase
1.13 KB, application/xhtml+xml
Details
proposed fix
2.58 KB, patch
jhpedemonte
: review+
smaug
: review+
Details | Diff | Splinter Review 
My patch for lazy authoring screwed up nsXFormsUtils::GetInstanceNodeForData. 
Arrrgh!  I changed the function to use my new instance list held by the model,
but I forgot to return the nsIDOMNode for the found instance element.
Attached file testcase — 
when you click on the show trigger, namespaces should be serialized on the
document.  That doesn't happen because of this bug.
Attached patch proposed fix — — Splinter Review 
fixes bug, cleans up some extraneous coding I'd done earlier.
Attachment #187864 - Flags: review?(jhpedemonte)
Attachment #187864 - Flags: review?(jhpedemonte) → review+
Attachment #187864 - Flags: review?(smaug)
Blocks: 297808
Attachment #187864 - Flags: review?(smaug) → review+
checked in
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: