299302 - Skip certain items in getIncompatibleItemList

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

getIncompatibleItemList on nsIExtensionManager should be able to provide a list
of incompatible items that EXCLUDES disabled items (since the user may not be
interested in using them anymore) and which excludes preconfigured items like
DOM Inspector, Reporter etc. 

Attaching a patch that accomplishes this. Ultimately I would like distributions
to be able to supply a list of "safe" items that they ship with but this will do
for tbird/fx 1.1.

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch

Comment 2

[Darin Fisher]

Comment on attachment 187879 [details] [diff] [review]
patch

Add "[e-mail]" to the list.

nit: can use global const for "app-global"

Looks good otherwise, r=darin

Be sure to inform bsmedberg of this hard coded list since I think he wants to
rename the extensions IDs.

Comment 3

[Benjamin Smedberg]

Comment on attachment 187879 [details] [diff] [review]
patch

eww, this is a dirty hack. Maybe we should just have a install.rdf arc which
specifies app-managed extensions? I really don't want to ship 1.1 with this,
though as a 1.1a2 hack it might be ok.

Comment 4

[Darin Fisher]

Comment on attachment 187879 [details] [diff] [review]
patch

put back the r+ (mid air collision)

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: use an arc instead, update reporter, domi

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

      if (appManaged && locationKey == KEY_APP_GLOBAL)

should be:

      if (!includeDisabled && appManaged && locationKey == KEY_APP_GLOBAL)

btw, so we only filter in the update UI - post update the incompatible
app-managed items will already be repaired. 

Comment 7

[Darin Fisher]

Comment on attachment 187884 [details] [diff] [review]
use an arc instead, update reporter, domi

r=darin (I think we should use this new arc to prevent updateURL from being
used, i.e., to avoid hitting UMO to update these built-in extensions)

I'm not sure appManaged is the best name, but it works.  It sounds like the
opposite of itemIsManagedIndependently, but those are entirely unrelated.  oh
well ;-)

Comment 8

[Robert Strong (they/them - no direct email)]

(In reply to comment #7)
> (From update of attachment 187884 [details] [diff] [review] [edit])
> r=darin (I think we should use this new arc to prevent updateURL from being
> used, i.e., to avoid hitting UMO to update these built-in extensions)
The patch that landed in bug 299887 accomplishes exactly that.