Closed Bug 299302 Opened 16 years ago Closed 16 years ago

Skip certain items in getIncompatibleItemList

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: bugs, Unassigned)

Details

Attachments

(1 file, 1 obsolete file)

getIncompatibleItemList on nsIExtensionManager should be able to provide a list
of incompatible items that EXCLUDES disabled items (since the user may not be
interested in using them anymore) and which excludes preconfigured items like
DOM Inspector, Reporter etc. 

Attaching a patch that accomplishes this. Ultimately I would like distributions
to be able to supply a list of "safe" items that they ship with but this will do
for tbird/fx 1.1.
Attached patch patch (obsolete) — Splinter Review
Attachment #187879 - Flags: review?(darin)
Comment on attachment 187879 [details] [diff] [review]
patch

Add "talkback@mozilla.org" to the list.

nit: can use global const for "app-global"

Looks good otherwise, r=darin

Be sure to inform bsmedberg of this hard coded list since I think he wants to
rename the extensions IDs.
Attachment #187879 - Flags: review?(darin) → review+
Comment on attachment 187879 [details] [diff] [review]
patch

eww, this is a dirty hack. Maybe we should just have a install.rdf arc which
specifies app-managed extensions? I really don't want to ship 1.1 with this,
though as a 1.1a2 hack it might be ok.
Attachment #187879 - Flags: review+ → review?(darin)
Comment on attachment 187879 [details] [diff] [review]
patch

put back the r+ (mid air collision)
Attachment #187879 - Flags: review?(darin) → review+
Attachment #187879 - Attachment is obsolete: true
Attachment #187884 - Flags: review?(darin)
      if (appManaged && locationKey == KEY_APP_GLOBAL)

should be:

      if (!includeDisabled && appManaged && locationKey == KEY_APP_GLOBAL)

btw, so we only filter in the update UI - post update the incompatible
app-managed items will already be repaired. 
Assignee: bugs → nobody
Comment on attachment 187884 [details] [diff] [review]
use an arc instead, update reporter, domi

r=darin (I think we should use this new arc to prevent updateURL from being
used, i.e., to avoid hitting UMO to update these built-in extensions)

I'm not sure appManaged is the best name, but it works.  It sounds like the
opposite of itemIsManagedIndependently, but those are entirely unrelated.  oh
well ;-)
Attachment #187884 - Flags: review?(darin) → review+
(In reply to comment #7)
> (From update of attachment 187884 [details] [diff] [review] [edit])
> r=darin (I think we should use this new arc to prevent updateURL from being
> used, i.e., to avoid hitting UMO to update these built-in extensions)
The patch that landed in bug 299887 accomplishes exactly that.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.