299312 - Make week view editing only use textboxes when editing

Status: RESOLVED FIXED

(Calendar :: Lightning Only, defect)

Description

[Stuart Parmenter]

Instead of always having a textbox in the event boxes, we should swap one in
when we go in to edit mode, otherwise just use a label.  This makes things much
faster.

Comment 1

[Stuart Parmenter]

Attachment: Fix

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 187890 [details] [diff] [review]
Fix

>       <property name="occurrence">
>         <getter><![CDATA[
>@@ -1262,9 +1267,9 @@
>         ]]></getter>
>         <setter><![CDATA[
>           this.mOccurrence = val;
>-          var evl = this.eventNameElement;
>+          var evl = this.eventNameLabel;
> 
>-          if (val) {
>+          if (val && val != "") {
>               evl.value = val.title;
>           } else {
>               evl.value = "Untitled Event";

If you use .value to set a label, you don't get the word wrapping and other
nice behaviour.  You need to create a text node and insert it as the label's
child (need to remove old child nodes of the label too).

>+          this.editingTimer = null;
>+          this.mOriginalTextLabel = this.eventNameLabel.value;

Just pull this from the event's summary property, not the label.

Comment 3

[Stuart Parmenter]

Attachment: updated

this fixes it to do what you said as well as adds support canceling on escape
and saving on enter.

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 187897 [details] [diff] [review]
updated

r=vladimir

Comment 5

[Stuart Parmenter]

checked in