299332 - Unable to move 100+ messages from one IMAP folder to another

Status: VERIFIED FIXED

(MailNews Core :: Networking, defect)

Description

[Boris Zbarsky [:bzbarsky]]

BUILD: Current trunk build.

STEPS TO REPRODUCE:

1)  Highlight 150 messages in an IMAP folder
2)  Try to move them to another IMAP folder

EXPECTED RESULTS:  Messages moved

ACTUAL RESULTS:  Messages copied to the new folder, then a "connection timed
out" message.

NOTE:  This means that I now have to manually deal with all the spam I got while
on vacation, since the same error occurs when mailnews tries to move the spam to
the Junk folder...

Could this be fallout from the work on letting sockets time out?

Comment 1

[David :Bienvenu]

these folders are on the same server? It's pretty unlikely - we issue the single
command to copy the messages, and then wait for a response, then delet the
original messages. If it takes a really long time on the server, then I suppose
it could time out, but it would have to be a really slow server. You can try
increasing the timeout and see if it helps, under tools | options | advanced

Comment 2

[Boris Zbarsky [:bzbarsky]]

Yes, the folders are on the same server.  We copy fine, the delete times out.

I'll try bumping the timeout and seeing what I get....

Comment 3

[Boris Zbarsky [:bzbarsky]]

I don't see a mailnews option to change this timeout in the suite... Is there one?

In any case, I manually changed the pref value to 300, and I get the same exact
result.  The messages are copied, but the delete times out.  This is with 167
messages that I was trying to move.

Comment 4

[David :Bienvenu]

it could be that the server isn't generating the right protocol as a response to
the copy or the delete, so we timeout waiting for it.

http://www.mozilla.org/quality/mailnews/mail-troubleshoot.html#imap

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: IMAP:5 log from startup to getting the timeout alert

Ah, excellent.	This is a log of the problem happening.

Comment 6

[David :Bienvenu]

my educated guess is that we're generating too long a command string to do the
copy, and the server is hanging, and not returning an error. This is a dup of an
existing bug, I'm pretty sure. I fixed this for the storing of flags, but not
COPY. There are two possible fixes, generating ranges and doing the copy with
multiple commands.

Comment 7

[David :Bienvenu]

this is only a problem on some servers.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Bug 221509 may be related, but it's hard to tell what the heck that bug is
actually about....

I realize this may only be a problem with some servers.  I just don't have much
choice of IMAP server here, and this bug pretty totally hoses spam filtering any
time I don't check email for more than a day or two.  :(

Comment 9

[David :Bienvenu]

Bug 221509  was not what I had in mind :-) there's one with a much better
description of the problem and solutions.

the problem for coalescing the ranges is that the info I need isn't readily
accessible at the time I need it. I'll have another crack at it this weekend. My
condolences, it's highly unfortunate that MIT settled on that rev of the server

Comment 10

[David :Bienvenu]

Attachment: proposed fix

break up copy into multiple commands, if command line gets long (over 950
bytes)

Comment 11

[David :Bienvenu]

fix checked in. Let me know if this fixes it for you, thx!

Comment 12

[Boris Zbarsky [:bzbarsky]]

Yeah, the move is near-instantaneous now.  Thanks!

Comment 13

[David :Bienvenu]

*** Bug 280088 has been marked as a duplicate of this bug. ***