299368 - Hide 'Print Preview' menu item in Mac OS X

Status: VERIFIED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Hiro]

Firefox does fix with bug228000. 
But in Thunderbird, it still remains. 

Mac OS X 10.3.9
Tb NB version 1.0+ (20050630)

Comment 1

[Hiro]

Print Preview still remains in Tb1.5 beta1.

Comment 2

[Hiro]

Attachment: patch

Print preview is hidden in main and the mail window. 
It remains in these two places now.

Comment 3

[Scott MacGregor]

Comment on attachment 211536 [details] [diff] [review]
patch

should we be hiding it from the addressbook too?

Comment 4

[Hiro]

(In reply to comment #3)
> (From update of attachment 211536 [details] [diff] [review] [edit])
> should we be hiding it from the addressbook too?

In addressbook, there is no Print Preview.
(1.8branch NB version 2 alpha 1 (20060308))

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

checked-in to trunk, thanks.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

It's still visible with a current 1.8 branch build of Thunderbird. We have a patch which should gracefully apply to the branch.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 211536 [details] [diff] [review]
patch

Very simple patch to remove the non-functional print preview menu entry on Mac OS X.

Comment 8

[Scott MacGregor]

Comment on attachment 211536 [details] [diff] [review]
patch

I think this is going to have to wait for 1.8.1.6. I'll approve it when the security branch opens for 1.8.1.6 changes.

Comment 9

[Scott MacGregor]

not a blocker for the branch.

Comment 10

[Daniel Veditz [:dveditz]]

mscott: see comment 8, branch is open for now, you've got a small window here

Comment 11

[Scott MacGregor]

Comment on attachment 211536 [details] [diff] [review]
patch

I'd like to get this into the branch. a=mscott

Comment 12

[Carsten Book [:Tomcat]]

(In reply to comment #11)
> (From update of attachment 211536 [details] [diff] [review])
> I'd like to get this into the branch. a=mscott
> 

the patch was checked in , see http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/mail/base/content/mailWindowOverlay.xul&rev=MOZILLA_1_8_BRANCH&root=/cvsroot

and i can verify fixed 1.8.1.7 this bug using Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.7pre) Gecko/20070830 Thunderbird/2.0.0.7pre ID:2007083003 - the print preview item is gone - adding verified keyword

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Same for trunk which was already fixed a while ago.