Closed Bug 299454 Opened 19 years ago Closed 19 years ago

Nickname drop-down button is not discoverable enough

Categories

(Other Applications :: ChatZilla, defect)

x86
All
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: bugzillamozilla, Assigned: neil)

Details

(Whiteboard: [cz-0.9.69])

Attachments

(2 files, 1 obsolete file)

The Nickname button in CZ is not discoverable enough. I just learned about it in
#chatzilla, while discussing the need for such a button.

Alternative suggestions:

1. Change its default look to the more inviting hovered-on look.
2. Put it on the future CZ toolbar (Bug 262024)
3. Add a real drop-down button to it (like in the URL bar).

Other options?

Prog.
I've tried switching to a <button type="menu"/> locally, and it almost does #1
(which is the only way I'm considering). Except XUL and/or Gecko is broken, and
the arrow ends up on the left!
I get approximately attachment 188029 [details] with the dropdown triangle, plus
button-hover effect, on gtk2. It probably should look more like a button to
begin with (it's completely flat w/o hover), like other similar buttons around
gtk2 apps. The xul dropmarker thing like on the url bar on the other hand is
huge and out of place anywhere except on the urlbar, imo :)
Yeah, I tried doing that and this is what happened:
  http://twpol.dyndns.org/temp/cz_away_1.png

It looks fine, except XUL is putting the arrow on the wrong side. :(

Otherwise, it is my preferred solution.
Attached patch Proposed patch (obsolete) — Splinter Review
Since the button is no longer a toolbar button I reverted the #input-widgets to
an hbox. I also replaced the #input-widgets CSS fixes with a #server-nick fix.
Assignee: rginda → neil.parkwaycc.co.uk
Status: NEW → ASSIGNED
Attachment #188067 - Flags: review?(silver)
Comment on attachment 188067 [details] [diff] [review]
Proposed patch

>Index: skin/chatzilla.css
>+#server-nick {
>+    -moz-box-direction: reverse;
> }

I can guess what this does, but *WHY* is it needed? The DOM is clearly in the
right order, but layout isn't (without this).
Comment on attachment 188067 [details] [diff] [review]
Proposed patch

You're right, there's something screwy with the XUL layout. I hadn't realized
that the dropmarker wasn't supposed to be on the left...
Attachment #188067 - Attachment is obsolete: true
Attachment #188067 - Flags: review?(silver) → review-
What is really puzzeling me is that <button type="menu"/> normally looks fine.
Even with a menupopup in it. It is only in this particular case it breaks. DOMI
also shows (via position of items) that the order is not simply reversed...

button(hbox(image, dropmarker, label))

That's the visual order given by the elements' positions, which is really odd
(the XBL clearly shows image, label, dropmarker).
Attached patch Better hackSplinter Review
This hack should be acceptable, or even understandable ;-)

The weirdness has to do with adding a label to a labelless menubutton.
I guess this is because a valueless label thinks it's an HTML container,
then setting the value on it morphs it into a croppable single-line text.
I've written a fairly minimal testcase and will be attaching it to a new bug.
Attachment #188131 - Flags: review?(silver)
Comment on attachment 188131 [details] [diff] [review]
Better hack

r=silver

Wow, that's some weird brokenness in the label (and why does what it "is"
affect its position?).
Attachment #188131 - Flags: review?(silver)
Attachment #188131 - Flags: review+
Attachment #188131 - Flags: approval1.8b3?
Attachment #188131 - Flags: approval1.8b3? → approval1.8b3+
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Verified with Chatzilla 0.9.67+ [SeaMonkey rv:1.8b3/20050713]

Thanks for everyone involved, I'm very happy with the final result.

Prog.
Status: RESOLVED → VERIFIED
Some users have expressed a strong dislike of the new button, but meh, we'll
sort it out over time. ;)
Whiteboard: [cz-0.9.69]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: