299494 - Crash when designmode on, print preview and then dragging link

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Martijn Wargers (dead)]

See upcoming testcase.
After step 4 I crash, but I would not expect to be able to drag a link, since
I'm still in designMode (or I still should be).

Comment 1

[Martijn Wargers (dead)]

Attachment: testcase

Comment 2

[J.P.Klippel]

reproduced with:
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.9) Gecko/20050630 Firefox/1.0.5

Comment 3

[Boris Zbarsky [:bzbarsky]]

So the crash happens because print preview wipes out the old presshell in most
cases (unless there are framesets or embeds or applets in it, see
nsPrintEngine::CheckDocumentForPPCaching()).  This fails for <object>, of
course, and messes up this case.  Is there a reason not to just always cache here?

In any case, the presshell dies but the editor doesn't know that, and some
editor code holds a weak ref to the shell that becomes bogus.  I'll attach a
patch for that; with that patch I don't crash, but designmode isn't really
working right either when I exit print preview.  Maybe that should be a separate
bug...

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix the crash

Both the editor and caret hold an nsWeakPtr, so this code should do the same...

Comment 5

[Johnny Stenback (:jst)]

Comment on attachment 188505 [details] [diff] [review]
Fix the crash

sr=jst

Comment 6

[Kathleen :Brade]

Comment on attachment 188505 [details] [diff] [review]
Fix the crash

r=brade

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 188505 [details] [diff] [review]
Fix the crash

Requesting 1.8b3 approval for this crash fix.  This is quite safe.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Bug 300165 filed for the remaining issues here, and fix checked in.