299521 - Implement time, version, userhost, userip and user commands

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, enhancement)

Description

[:Gijs (he/him)]

As in topic. Afterwards, normal users should be able to access all the 'normal'
commands they expect. I'll make another bug + patch (hopefully) for the IRCop
commands. They all work already, but it's nicer if we actually list ChatZilla as
'understanding' them, IMHO.

Comment 1

[James Ross]

[USAGE]	version <nickname>
[HELP]	Asks <nickname> what irc client they're running. Their IRC client may or
may not show them that you've asked for this information. ChatZilla currently
does not.

Also, not all of these commands are universally supported. See the
cmds=KNOCK,MAP,DCCALLOW,USERIP parameter in irc.mozilla.org's RPL_ISUPPORT message.

Comment 2

[James Ross]

Useful code for detecting userip may be found in attachment 188137 [details] [diff] [review] of bug 299458.

Comment 3

[:Gijs (he/him)]

Attachment: Patch

Patch 'done', finally. Requesting review.

In addition to the changes described above, this patch also makes sure /name,
/desc and /user manipulate the network preferences instead of the global one
when used from a network/channel/user view.

Silver's patch for the supported commands thing has since been checked in, as
far as I can tell.

Comment 4

[Robert Ginda]

Comment on attachment 192561 [details] [diff] [review]
Patch

You could do cmdName and cmdDesc as a single function that switched on
e.command.name, but it's not strictly necessary.

r=rginda

Comment 5

[Robert Ginda]

Comment on attachment 192561 [details] [diff] [review]
Patch

r=rginda

Comment 6

[James Ross]

Checked in --> FIXED.