299548 - Fails to focus the content area when loading homepage

Status: RESOLVED FIXED

(Camino Graveyard :: HTML Form Controls, defect)

Description

[Taral]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050701 Camino/0.9a1+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050701 Camino/0.9a1+

When Google is brought up, the search box is supposed to be given focus by an
onload routine. It's not, and running "document.f.q.focus()" by hand (url bar)
doesn't do it either.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Wevah (Nate Weaver)]

This works fine for me in the July 3rd nightly. Does anything show up in the
Console log?

Comment 2

[Taral]

Aha, new steps:

1. Set home page to "http://www.google.com/"
2. Open new tab.
3. Hit cmd-shift-H to go to homepage.

Expected result: input field is focused.
Actual result: input field not focused.

Comment 3

[Wevah (Nate Weaver)]

Ah, you're right. It seems that the focus is never taken away from the URL bar
(if it's focused) when going to whatever the home page is set to.

Comment 4

[Wevah (Nate Weaver)]

Dropping severity.

Comment 5

[Wevah (Nate Weaver)]

I think the offending line is
http://lxr.mozilla.org/mozilla/source/camino/src/browser/BrowserWindowController.mm#2162:

[mBrowserView loadURI:[[PreferenceManager sharedInstance] homePage:NO] referrer:
nil flags:NSLoadFlagsNone activate:NO allowPopups:NO];

We should probably be passing activate:YES instead, which sets the "pending
active" of mBrowserView (a BrowserWrapper).

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Is this a quick fix, Wevah?

Comment 7

[Wevah (Nate Weaver)]

*** Bug 314641 has been marked as a duplicate of this bug. ***

Comment 8

[Wevah (Nate Weaver)]

(In reply to comment #6)
> Is this a quick fix, Wevah?

I don't even know if my proposed fix works, to be honest; someone will have to check it.

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Giving this a more general summary in line with comment 3 so I don't accidentally reopen bug Bug 314641 :-)

Was: Javascript HTMLInputElement.focus() fails to focus element when loading homepage

See also bug 310395 where a similar problem occurs under different circumstances.

Comment 10

[Samuel Sidler (old account; do not CC)]

Gijs: Are you sure this bug is really dependent on the other?

Comment 11

[froodian (Ian Leue)]

I have a working patch for this, which I'll upload once I find a find a connection fast enough to update my source. -> me

Comment 12

[froodian (Ian Leue)]

Attachment: Makes the homepage get focus

This essentially just does what Wevah said.  I tested it out, and it seems to work as expected.

Comment 13

[froodian (Ian Leue)]

The fix for this is in Bug 310395 (sorry about wasting your time with the duplicate r?'s hwaara, since you'll have to review it there)

Comment 14

[froodian (Ian Leue)]

Fixed by bug 310395.