299581 - Mac application menu still named "Mozilla"

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Stefan [:stefanh]]

SeaMonkey 2005070312, Mac OS 10.3.9.

The SeaMonkey rebranding, done in bug 285696, hasn't fixed the mac application
menu. It's still named "Mozilla".

Comment 1

[Stefan [:stefanh]]

And of course the menuitems still says "About Mozilla", "Hide Mozilla" and "Quit
Mozilla"...

Comment 2

[Stefan [:stefanh]]

(In reply to comment #1)
> And of course the menuitems still says "About Mozilla", "Hide Mozilla" and "Quit
> Mozilla"...
> 
Sorry, the "About" menuitem is correctly named "About SeaMonkey".

Comment 3

[Karsten Düsterloh]

Attachment: Rebranded InfoPlist.strings (no diff since CVS regards UCS2BE as binary)

stefan_h's observation in bug 288192 is right: rebranding InfoPlist.strings
fixes this.

Comment 4

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 188468 [details]
Rebranded InfoPlist.strings (no diff since CVS regards UCS2BE as binary)

+ NSHumanReadableCopyright = "Copyright © 1998-2005 mozilla.org.";

check the other copyrights on firefox and camino. The copyright is not held by
m.o, it's held by the contributors to the code. it should be:

(c) 1998-2005 Contributors.

Comment 5

[Karsten Düsterloh]

Gerv,

most of the files now rebranded as SeaMonkey still have the (c) mozilla.org
notice (I am told). A notice of "(c) 1998-2005 Contributors." is pretty stupid
imo (sorry, pink) - what contributors? Of what? To what?
Do we need to change that at all? Code changes are (still) a+'d by staff before
checkin... 
If we need to, maybe we could go for 
"(c) 1998-2005 Mozilla.org Contributors." or
"(c) 1998-2005 Mozilla.org and Contributors."?

Comment 6

[Stefan [:stefanh]]

(In reply to comment #5)
> Gerv,
> 
> most of the files now rebranded as SeaMonkey still have the (c) mozilla.org
> notice (I am told). A notice of "(c) 1998-2005 Contributors." is pretty stupid
> imo (sorry, pink) - what contributors? Of what? To what?
> Do we need to change that at all? Code changes are (still) a+'d by staff before
> checkin... 
> If we need to, maybe we could go for 
> "(c) 1998-2005 Mozilla.org Contributors." or
> "(c) 1998-2005 Mozilla.org and Contributors."?

The question with Mozilla.org is of course who that/they are. afaik there is no
such thing as Mozilla.org. If you don't mean the domain, of course... ;) 

Comment 7

[Karsten Düsterloh]

> The question with Mozilla.org is of course who that/they are. afaik there is no
> such thing as Mozilla.org. If you don't mean the domain, of course... ;) 

Well, the original file /has/ "Copyright © 1998-2004 mozilla.org." - whatever
that may be, I didn't invent it. I just updated the year! :-)

And since Gerv is the MoFo's licencing guy, he should know what to do here. :)

Comment 8

[Gervase Markham [:gerv]]

Where does this string appear, and in what UI?

Gerv

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

mozilla.org is just wrong. the copyright is held by lots of people, and some are
not at all related to this project (e.g. zlib authors, libpng authors).

Comment 10

[Karsten Düsterloh]

[I'm still not that experienced in Mac development, especially not in
Mozilla-on-Mac development, so all the Mac gurus reading here, please correct me
if I'm telling nonsens!]

As far as I can tell after some research, it's (a) only used for Cocoa
applications and (b) not by us:
Only those applications need to provide the NSHumanReadableCopyright key in
their InfoPlist.strings file that have a *.plist file defining it - which we
don't. Nowhere. This string is not used.
One could say it's there because Apple recommends it, but that doesn't hold
because Apple also recommends a couple of other keys that we don't provide,
either
(<http://developer.apple.com/documentation/MacOSX/Conceptual/BPRuntimeConfig/Tasks/ConfigApplications.html>).

So I'd say we drop the NSHumanReadableCopyright line.

Comments?

Comment 11

[Benjamin Smedberg]

The human-readable-copyright line is used in the Finder when you view the
application bundle. You will see the copyright information at the bottom of the
finder display.

Comment 12

[Karsten Düsterloh]

> The human-readable-copyright line is used in the Finder when you view the
> application bundle. You will see the copyright information at the bottom of the
> finder display.

Hm, it doesn't for me with OS X Tiger. I get a copyright notice when doing
File->Get Info, but that isn't the string defined here. So what do you mean by
"viewing the app bundle"?

Comment 13

[Stefan [:stefanh]]

Hmm, looking at the stuff in
http://lxr.mozilla.org/seamonkey/source/xpfe/bootstrap/macbuild/Contents/Resources/English.lproj/InfoPlist.strings?raw=1

it looks like only 'CFBundleName = "Mozilla";' is in use. I can't seem to find
any "Copyright © 1998-2003 mozilla.org." appearing. Instead I see "(c) 1998-2005
The Mozilla Organization" if I do "Show Info" on the Seamonkey app icon.

Comment 14

[Gervase Markham [:gerv]]

If it has to say something, have it say:

(c) 1998-2005 Contributors to mozilla.org.

But it might be best, if it's not used, to just remove it.

Gerv

Comment 15

[Karsten Düsterloh]

Attachment: Rebranded InfoPlist.strings; without copyright string

When the finder looks for strings to display for an application, it takes
<app>/Contents/Info.plist, (partly) translated by
<app>/Contents/Resources/English.lproj/InfoPList.strings. Only those strings
are used from the latter file that are used by the first - and
NSHumanReadableCopyright isn't, thus removing.

Comment 16

[Karsten Düsterloh]

Attachment: Different approach: adding strings instead of removing them

Here's a different approach: instead of removing the NSHumanReadableCopyright,
I added it to Info.PList.in also. OTOH, I put CFBundleGetInfoString into
InfoPlist.strings to get it translated properly, too.
(This diff is kinda faked for reviewing purposes - InfoPlist.strings is UTF-16
and thus considered binary by CVS. I'd suggest we change that to UTF-8 also!)

Comment 17

[Mike Pinkerton (not reading bugmail)]

looks ok, except why not make the two versions of |NSHumanReadableCopyright| be
the same in the two files?

Comment 18

[Karsten Düsterloh]

Attachment: like 190738, but with identical copyright notices

Updated to comment #17.

Comment 19

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 191719 [details] [diff] [review]
like 190738, but with identical copyright notices

r=pink

Comment 20

[Karsten Düsterloh]

Comment on attachment 191719 [details] [diff] [review]
like 190738, but with identical copyright notices

triple minority (SM, Mac, wording) only ;-)

Comment 21

[Karsten Düsterloh]

Checked in into trunk and MOZILLA_1_8_BRANCH.