299587 - Quite a few grammar errors in Mozilla localization technical details

Status: RESOLVED FIXED

(www.mozilla.org :: General, defect)

Description

[Hendrik Maryns]

Verbs misconjugated etc.  See the patch.

Comment 1

[Hendrik Maryns]

Attachment: corrects the errors

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 188152 [details] [diff] [review]
corrects the errors

> This hides to the localizer many technical tedious details.

hides from, not hides to (and "from the localizer" really belongs at the end of
the sentence)

>- They have to follow each system customary.</p></li>
>+ They have to follow each system's customary.</p></li>

custom, not customary, although convention is probably better

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(In reply to comment #2)
> (From update of attachment 188152 [details] [diff] [review] [edit])
> > This hides to the localizer many technical tedious details.

and tedious should be before technical

Comment 4

[Hendrik Maryns]

Attachment: Comments applied

Applied your comments.	Hope this is a correct patch syntax, as I directly
edited the patch file, but it should work.

Comment 5

[Hendrik Maryns]

Comment on attachment 188228 [details] [diff] [review]
Comments applied

Is something going to happen with this?

Comment 6

[fantasai]

Comment on attachment 188228 [details] [diff] [review]
Comments applied

> Likely, for Unix and MacOS,

Similarly, for Unix and MacOS

You're missing the space after a few + and - near the top of the patch

> list of entities which need

list of entities that need

> operative system specific

operating system specific

r=fantasai with those changes.

Comment 7

[Hendrik Maryns]

Attachment: more comments applied

Once again, someone else has to check this in.	It is still far from prefect,
btw.

Comment 8

[fantasai]

Comment on attachment 193135 [details] [diff] [review]
more comments applied

There are still a lot of +/- without a following space, which makes me think
the patch won't apply cleanly. But as for the changes themselves, r=fantasai.

Comment 9

[victory <[e-mail]>]

commited. I applied the patch by hand so there's no problem fantasai mentioned.

Hendrik Maryns: edit local file(mlp_what2.html in this case) itself and do diff
instead of editing old diff.
In your way, let people other than yourself to find the new attachment is
actually new or not becomes hard work.

Comment 10

[Hendrik Maryns]

(In reply to comment #9)
> commited. I applied the patch by hand so there's no problem fantasai mentioned.

There wouldn't have been a problem.  It was correct.

> Hendrik Maryns: edit local file(mlp_what2.html in this case) itself and do diff
> instead of editing old diff.
> In your way, let people other than yourself to find the new attachment is
> actually new or not becomes hard work.

I don't really follow you but ok, next time better :-)