299594 - In the Download Actions dialogue, when the MIME Type column is shown, the Action column cannot be resized

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P4)

Description

[Grey Nicholson (they/them)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050703 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050703 Firefox/1.0+

In Tools > Options > Downloads > Download Actions > View & Edit Actions, the
Action column cannot be resized by dragging the column dividers. This only
applies when the MIME Type column is shown; by default it's hidden and this bug
does not occur.

Reproducible: Always

Steps to Reproduce:
1. Tools > Options > Downloads > Download Actions > View & Edit Actions
2. Click the choose columns to show icon, above the vertical scroll bar
3. Check MIME Types
4. Try to resize the Action column by dragging the divider at the left side of
its column header
Actual Results:  
The divider cannot be dragged

Expected Results:  
Dragging the divider should resize the columns as usual

Comment 1

[Adam Guthrie]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050704
Firefox/1.0+ ID:2005070405

Confirming.

Comment 2

[Mike Schroepfer]

Would approve low-risk fix - but don't think this is severe enough to block the
beta release.

Comment 3

[tinymammoth]

Hmmm... still id Deer Park

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060105 
Firefox/1.6a1

Comment 4

[Adam Guthrie]

Attachment: patch

So basically what's happening is that the Actions column gets the <splitter> when MIME Type column is hidden, but when the MIME Type column is unhidden the Actions column is left without a <splitter>.

Seems like the <splitter> should be hidden when its neighboring column is hidden, but that's probably another bug.

I took off the flex="true" because it was misspelled and not doing anything. This is keeping the same behavior of not resizing the File Type column when the window gets resized, which makes sense to me.

Comment 5

[Adam Guthrie]

Attachment: patch for Thunderbird

Same fix as for Firefox, just "ported" to Thunderbird's fork. :) See comment 4 for explanation.

Comment 6

[Asaf Romano (gone)]

Checking in downloadactions.xul;
/cvsroot/mozilla/browser/components/preferences/downloadactions.xul,v  <--  downloadactions.xul
new revision: 1.9; previous revision: 1.8
done

Comment 7

[:Gavin Sharp [email: [e-mail]]]

mozilla/mail/components/preferences/downloadactions.xul; new revision: 1.5;