Closed Bug 299624 Opened 19 years ago Closed 19 years ago

btek Tp increase due to rebranding patches

Categories

(SeaMonkey :: General, defect)

Product:
SeaMonkey
Component:
General
Type:
defect
Priority:
Not set
Severity:
blocker

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: kairo, Unassigned)

Details

btek Tp went up from 835ms to 905ms after checking in the rebranding changes
(mainly bug 285696 stage 2), that's an 8% regression.

Temporarily backing out the throbber changes (first Classic, then Modern) didn't
have any effect, we should invenstigate further where this comes from.

As Tp didn't change on luna, it may very well be a machine-specific thing
though, Chase meant to me "btek is like that", noting that a simple patch name
change on the box had a similar effect once and he had to revert that back then.
Flags: blocking-seamonkey1.0a+
Given that btek is our main Tp measurement machine (it's much more accurate than
the others, because it's slower), I'd really like to see this resolved ASAP....
Severity: normal → blocker
btek Tp before the checkins:

Avg. Median : 836 msec
Average     : 878 msec
Minimum     : 170 msec
Maximum     : 2743 msec

IDX PATH                         AVG  MED  MAX  MIN TIMES ...
  0 home.netscape.com            802  689 1279  668 1279  668  690  689  686
  1 my.netscape.com              786  749  948  739  948  739  750  749  744
  2 www.aol.com                  768  715  991  709  991  710  719  715  709
  3 www.mapquest.com             484  428  705  411  705  428  416  411  460
  4 www.moviefone.com            591  554  754  547  754  556  547  547  554
  5 www.digitalcity.com          650  600  853  596  853  600  596  597  605
  6 www.iplanet.com              710  648  990  623  990  623  639  648  650
  7 web.icq.com                 1271 1215 1506 1209 1506 1215 1209 1210 1218
  8 www.compuserve.com           689  661  766  656  766  659  656  661  704
  9 www.msnbc.com                583  515  858  512  858  515  512  517  515
 10 www.yahoo.com                397  396  410  391  410  391  398  396  392
 11 bugzilla.mozilla.org         884  879  911  876  911  876  879  882  876
 12 www.msn.com                  826  791  980  785  980  792  785  791  785
 13 slashdot.org                 676  654  780  641  780  654  652  655  641
 14 www.nytimes.com             1026  919 1467  914 1467  919  919  915  914
 15 www.nytimes.com_Table       1760 1738 1859 1727 1859 1742 1738 1727 1737
 16 www.w3.org_DOML2Core        2676 2708 2743 2511 2683 2743 2737 2511 2708
 17 lxr.mozilla.org             1622 1577 1806 1569 1806 1577 1571 1569 1587
 18 espn.go.com                  839  825  896  818  896  840  818  818  825
 19 www.voodooextreme.com       2275 2116 2727 2101 2727 2116 2101 2326 2108
 20 www.wired.com                813  770 1000  758 1000  770  758  765  772
 21 hotwired.lycos.com           597  568  716  568  716  568  568  568  568
 22 www.ebay.com                 531  488  716  477  716  480  477  488  494
 23 www.apple.com                422  407  509  375  509  405  375  407  417
 24 www.amazon.com               610  571  771  565  771  570  565  571  575
 25 www.altavista.com            447  427  525  425  525  426  427  425  432
 26 www.zdnet.com_Gamespot.com  1080 1003 1404  994 1404  995  994 1003 1006
 27 www.spinner.com              723  697  840  688  840  691  688  703  697
 28 www.microsoft.com            601  579  682  578  682  579  578  590  579
 29 www.time.com                 809  720 1187  710 1187  710  720  720  712
 30 www.travelocity.com          897  893  917  885  917  893  901  885  891
 31 www.expedia.com              826  759 1108  752 1108  760  759  752  752
 32 www.quicken.com              535  522  602  509  602  522  519  523  509
 33 www.zdnet.com               1122 1055 1405 1047 1405 1047 1048 1059 1055
 34 www.excite.com               817  787  939  784  939  791  784  784  787
 35 www.google.com               199  185  278  170  278  190  185  170  176
 36 www.tomshardware.com        1237 1196 1410 1192 1410 1192 1196 1196 1192
 37 www.cnn.com                 1376 1328 1571 1323 1571 1324 1323 1336 1328
 38 news.cnet.com                751  716  897  710  897  710  716  718  715
 39 www.sun.com                  439  429  484  424  484  424  434  424  429


And after the checkins:

Avg. Median : 906 msec
Average     : 946 msec
Minimum     : 237 msec
Maximum     : 2812 msec

IDX PATH                         AVG  MED  MAX  MIN TIMES ...
  0 home.netscape.com            856  757 1261  749 1261  749  757  755  759
  1 my.netscape.com              790  762  908  758  908  758  761  765  762
  2 www.aol.com                  847  790 1081  784 1081  789  784  795  790
  3 www.mapquest.com             542  493  754  483  754  485  483  493  496
  4 www.moviefone.com            654  623  793  616  793  623  623  617  616
  5 www.digitalcity.com          716  667  911  662  911  662  676  667  667
  6 www.iplanet.com              772  714 1033  696 1033  714  698  696  722
  7 web.icq.com                 1328 1291 1491 1276 1491 1276 1291 1296 1288
  8 www.compuserve.com           746  719  849  717  849  717  730  718  719
  9 www.msnbc.com                648  587  897  585  897  585  585  588  587
 10 www.yahoo.com                466  461  490  455  490  455  455  461  471
 11 bugzilla.mozilla.org         958  945 1019  939 1019  941  950  945  939
 12 www.msn.com                  903  866 1060  860 1060  860  872  866  860
 13 slashdot.org                 739  727  799  718  799  718  726  728  727
 14 www.nytimes.com             1115 1001 1571  997 1571  999 1010 1001  997
 15 www.nytimes.com_Table       1829 1801 1946 1798 1946 1802 1798 1799 1801
 16 www.w3.org_DOML2Core        2793 2802 2812 2764 2764 2812 2784 2802 2804
 17 lxr.mozilla.org             1706 1661 1883 1653 1883 1673 1653 1661 1661
 18 espn.go.com                  905  892  970  884  970  884  886  892  894
 19 www.voodooextreme.com       2309 2192 2791 2180 2791 2180 2190 2196 2192
 20 www.wired.com                881  834 1078  824 1078  836  824  833  834
 21 hotwired.lycos.com           681  658  742  658  742  658  658  693  658
 22 www.ebay.com                 605  559  787  553  787  553  559  570  559
 23 www.apple.com                503  471  660  452  660  452  476  471  459
 24 www.amazon.com               699  667  846  655  846  655  660  670  667
 25 www.altavista.com            551  543  585  539  585  539  549  541  543
 26 www.zdnet.com_Gamespot.com  1174 1090 1508 1088 1508 1090 1095 1088 1090
 27 www.spinner.com              782  750  906  749  906  757  750  749  750
 28 www.microsoft.com            654  652  668  647  668  652  647  658  648
 29 www.time.com                 879  787 1260  779 1260  787  788  783  779
 30 www.travelocity.com          966  962  987  959  987  963  962  961  959
 31 www.expedia.com              907  839 1182  838 1182  838  839  839  838
 32 www.quicken.com              605  593  659  590  659  593  596  590  590
 33 www.zdnet.com               1199 1139 1441 1136 1441 1144 1139 1138 1136
 34 www.excite.com               899  871 1015  870 1015  872  870  871  871
 35 www.google.com               259  246  330  237  330  238  247  237  246
 36 www.tomshardware.com        1217 1132 1456 1125 1456 1246 1129 1125 1132
 37 www.cnn.com                 1459 1411 1655 1399 1655 1399 1420 1411 1410
 38 news.cnet.com                819  789  949  783  949  789  785  789  783
 39 www.sun.com                  515  499  576  498  576  499  498  505  499


So, it's pretty much everywhere, there seems nothing page-specific about it...
I tried backing out the UA change, but without any effect.
OK, I'll go through my file list from the main checkin (others at the same time
did only affect packaging and win installer, which do both not affect btek
running the pageload tests on Linux) for you again, to check what possible
impact they may have had:

mozilla/configure.in
- main change:
    MOZ_APP_NAME from "mozilla to "seamonkey",
    MOZ_APP_DISPLYNAME from "Mozilla" to "SeaMonkey",
    MOZ_APP_VERSION from MOZILLA_VERSION to the value of version.txt
- checking in or backing out of that part breaks all tinderboxen and
    needed/needs a tinderbox config change to reflect the new binary name

mozilla/themes/classic/communicator/brand/throbber16-anim.gif
mozilla/themes/classic/communicator/brand/throbber16-single.gif
mozilla/themes/classic/communicator/brand/throbber-anim.gif
mozilla/themes/classic/communicator/brand/throbber-single.gif
mozilla/themes/modern/communicator/brand/throbber16-anim.gif
mozilla/themes/modern/communicator/brand/throbber16-single.gif
mozilla/themes/modern/communicator/brand/throbber-anim.gif
mozilla/themes/modern/communicator/brand/throbber-single.gif

- throbber images - backing them out showed no Tp effect.

mozilla/xpfe/bootstrap/browser-prefs.js

- UA string change, backout showed no Tp effect

mozilla/xpfe/bootstrap/module.ver
mozilla/xpfe/bootstrap/mozilla.icns
mozilla/xpfe/bootstrap/mozilla.ico
mozilla/xpfe/bootstrap/mozos2.ico
mozilla/xpfe/bootstrap/splash.bmp
mozilla/xpfe/bootstrap/appleevents/mozilla.sdef

- all those aren't built by btek (win/mac/os2-specific)

mozilla/xpfe/bootstrap/splash.xpm

- Linux splash, backout showed no Tp effect

mozilla/xpfe/bootstrap/version.txt

- only used at build time to set MOZ_APP_VERSION

mozilla/xpfe/bootstrap/init.d/README

- simple string changes, just ends up in init.d dir without any further effect

mozilla/profile/defaults/bookmarks.html

- replaced three bookmarks in default set with two others, renamed another
    clean, small change that should have no effect, new file is smaller

mozilla/editor/ui/locales/en-US/chrome/region/region.properties
mozilla/mailnews/base/resources/locale/en-US/region.properties
mozilla/xpfe/browser/resources/locale/en-US/region.properties

- throbber URL change:
    mozilla.org/products/mozilla1.x/ --> mozilla.org/projects/seamonkey/

mozilla/xpfe/communicator/resources/locale/en-US/brand.dtd
mozilla/xpfe/communicator/resources/locale/en-US/brand.properties

- brandShortName/vendorShortName: "Mozilla" --> "SeaMonkey"
    this is the main change to show the new name in UI

mozilla/xpfe/components/search/resources/locale/en-US/default.htm

- one change of s/Mozilla/SeaMonkey in normal HTML text

mozilla/xpfe/global/resources/content/logo.gif

- about:logo (only shown on about: page, should never be called by btek)

mozilla/xpfe/global/resources/locale/en-US/region.dtd

- vendorURL change: mozilla.org/ --> mozilla.org/projects/seamonkey/


I really don't see what else but the already tested backouts could affect btek's
numbers, if not the basic stuff, or Chase's changes to the tinderbox config
(mozilla-bin --> seamonkey-bin).

As Chase stated he once has moved the tinderbox scripts into a subdir on btek,
and it ended up with a similar Tp increase, I tend to believe the slight change
of the tinderbox config or something similar caused the increase :(

Someonme stated "btek is both a pain and a blessing".

Any other ideas?
I'd love it if we could test a backout of everything but the tinderbox config
changes.  If that doesn't help, then I guess we chalk it up to ending up on a
different part of the disk with more fragmentation or something.  :(
(In reply to comment #5)
> I'd love it if we could test a backout of everything but the tinderbox config
> changes.  If that doesn't help, then I guess we chalk it up to ending up on a
> different part of the disk with more fragmentation or something.  :(

Hmm, that brings up an idea I had for some time now: btek is a Dep box, and as
some files (the binary and the start script among others) were renamed due to
the configure changes, the old and new parts may be both lying around in
dist/bin now, unless this is cleaned up at every respin... May this cause problems?
Hmm... no idea.  Worth checking out, for certain!  Chase, would it be possible
to wipe the objdir on btek and restart it?
(In reply to comment #7)
> Hmm... no idea.  Worth checking out, for certain!  Chase, would it be possible
> to wipe the objdir on btek and restart it?

Yes!  btek builds in its source directory so I removed its checkout and
restarted the build scripts.
(In reply to comment #8)
> Yes!  btek builds in its source directory so I removed its checkout and
> restarted the build scripts.

Interestingly, that had no effect at all on Tp...

I've tried now a backout of all further UI files that are built on Linux:

profile/defaults/bookmarks.html
mailnews/base/resources/locale/en-US/region.properties
editor/ui/locales/en-US/chrome/region/region.properties
xpfe/components/search/resources/locale/en-US/default.htm
xpfe/global/resources/locale/en-US/region.dtd
xpfe/browser/resources/locale/en-US/region.properties
xpfe/global/resources/content/logo.gif
xpfe/communicator/resources/locale/en-US/brand.properties
xpfe/communicator/resources/locale/en-US/brand.dtd

Let's see how btek reacts to that...
(In reply to comment #9)
> I've tried now a backout of all further UI files that are built on Linux:

Again no effect.

Now all what I didn't try to back out are non-Linux files and the main
configure.in/version.txt change, which is known to break all tinderboxen.
OK.  I guess we do chalk this up to some sort of unexplained btek thing, then...  :(
(In reply to comment #11)
> OK.  I guess we do chalk this up to some sort of unexplained btek thing,
then...  :(

I'd actually be happy if we didn't need to, but everything very much points that
way :(
I really hate unresolved mysteries, but it looks like this is one :(
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.