299628 - Compile time-errors in nsXFormsModelElement.cpp and nsXFormsSchemaValidator.cpp

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[Allan Beaufour]

bug 294441 and bug 278447 creates compile-time errors:
nsXFormsModelElement.cpp: In member function `virtual nsresult 
   nsXFormsModelElement::FindInstanceElement(const nsAString_internal&, 
   nsIInstanceElementPrivate**)':
nsXFormsModelElement.cpp:1018: warning: comparison between signed and unsigned 
   integer expressions
nsXFormsModelElement.cpp: In member function `void 
   nsXFormsModelElement::BackupOrRestoreInstanceData(int)':
nsXFormsModelElement.cpp:1279: warning: comparison between signed and unsigned 
   integer expressions
nsXFormsSchemaValidator.cpp: In member function `PRBool 
   nsXFormsSchemaValidator::GetType(const nsAString_internal&, const 
   nsAString_internal&, nsISchemaType**)':
nsXFormsSchemaValidator.cpp:119: warning: unused variable `PRBool success'

I _hate_ warnings when I compile.

Comment 1

[Allan Beaufour]

Attachment: Patch

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

checked in