299699 - don't check for "Internet" property in "Email" line of vCard

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[J Luh]

Thunderbird requires an "Email" property in a vCard object to contain the
parameter "Internet" indicating an Internet address type:

EMAIL;INTERNET:[e-mail]

However, Thunderbird should accept

EMAIL:[e-mail]

because INTERNET is the default in vCard 2.1
(http://www.imc.org/pdi/vcard-21.txt). The same is true in vCard 3.0 (RFC 2426).
I will attach a patch that fixes this.

I suppose the really correct thing to do would be to make sure the vCard does
not specify a non-Internet address type (X.400, eWorld, etc.), but that would
probably be overkill--I doubt there are many vCards floating around with eWorld
addresses in them.

Comment 1

[J Luh]

Attachment: simple patch to make vCard parsing more lenient

tested in my Mac OS X build, seems to work

Comment 2

[J Luh]

Attachment: patch to make vCard parsing more lenient

tested in Mac OS X build

Comment 3

[Scott MacGregor]

Comment on attachment 188272 [details] [diff] [review]
patch to make vCard parsing more lenient

this looks pretty straight forward to me. 

My only question is, if internet is the assumed default, are there are other
valid values that we would now be incorrectly assuming as email addresses?

i.e. with this change

email;randomprop:myaddress

would now end up as an address where before we would have skipped it.

Comment 4

[David :Bienvenu]

Comment on attachment 188272 [details] [diff] [review]
patch to make vCard parsing more lenient

seems OK to me - I agree that eWorld addresses aren't going to be too common. I
think the internet has won :-)

Comment 5

[J Luh]

Comment on attachment 188272 [details] [diff] [review]
patch to make vCard parsing more lenient

re: comment 3 and comment 4, yeah, I think in this case doing fewer checks on
the type is optimal even if one out of every 10,000 times it's the wrong thing
to do.

Comment 6

[J Luh]

Thanks -- mscott or bienvenu, can you please check this patch in and mark the
bug resolved? I don't have checkin privileges. (Patch has r, sr, and approval1.8b4).

Comment 7

[Scott MacGregor]

fixed. thanks for the patch. 

Comment 8

[Mark Banner (:standard8)]

*** Bug 229001 has been marked as a duplicate of this bug. ***