299700 - Automatically check for updates for "my extensions and themes" is unchecked after checking manually

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Dan Fischbach]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050704 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050704 Firefox/1.0+

Whenever I check for updates to my extensions and themes manually, the checkbox
to autocheck for updates to my extensions and themes is automatically unchecked.
 Even though I sometimes like to check for updates manually doesn't mean I would
like to check manually _all_ the time....
Zip build
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050704
Firefox/1.0+ ID:2005070405

Reproducible: Always

Steps to Reproduce:
1. Open up DPa1
2. Go to Tools -> Options -> Advanced -> Update
3. Check the box labeled "My Extensions and Themes"
4. Click the "Check Now..." button under the aforementioned checkbox
5. Click the "Finish" or "Cancel" buttons to exit the update window (doesn't
matter if it's done checking or not)
6. Notice that now the "My Extensions and Themes" checkbox is unchecked.


Expected Results:  
The autoupdate extensions and themes checkbox should have remained checked (FF
1.0.4 does this perfectly).

Comment 1

[Mike Connor [:mconnor]]

its a bug, yes, but not something we'll hold 1.8b3 for at the last minute...

Comment 2

[Dan Fischbach]

As a side note, this ONLY happens when you do a "Check Now..." in PrefWindow V.
 This does NOT happen when you are in the Extensions manager and right-click an
extension and choose to check for updates for that extension.

So this seems to confirm that it is a problem in PrefWindow V.

Comment 3

[Grayson Mixon (ColdFusion650)]

sounds like its the exact same problem that happened with the app update thing.

Comment 4

[Dan Fischbach]

Mike Conner said that this bug will not block 1.8b3.

Comment 5

[Jaime Mitchell (use [e-mail] for email)]

*** Bug 300976 has been marked as a duplicate of this bug. ***

Comment 6

[Aaron Slunt]

Attachment: patch

Previously, the preference attribute was set on the button (which I saw is NOT
set on the DP check now button). Removing the attribute fixes this bug for me.
Seems to be the correct way to me.

Comment 7

[Ben Goodger (use ben at mozilla dot org for email)]

This is not the right fix, I don't think. We were using this preference as a way
to control the disabled state of this button based on the lockedness of the
autoUpdateEnabled pref. Perhaps, instead, there should be a separate
disable_buttons preference to do this. Either way, this patch removes
functionality. 

Comment 8

[Aaron Slunt]

Comment on attachment 189494 [details] [diff] [review]
patch

Didn't see the locked pref thing. Thanks.

Two questions though:

1) Will bug 296566 have any impact on this?

2) Will a small js hack be appropriate to keep the checkbox checked?

Comment 9

[Bill Gianopoulos [:WG9s]]

(In reply to comment #7)
> This is not the right fix, I don't think. We were using this preference as a way
> to control the disabled state of this button based on the lockedness of the
> autoUpdateEnabled pref. Perhaps, instead, there should be a separate
> disable_buttons preference to do this. Either way, this patch removes
> functionality. 

I am not sure I understand what you are saying.  Is the intent here to prevent
an automatic check for extension update to fire during a manual chaeck?

Comment 10

[Jaime Mitchell (use [e-mail] for email)]

*** Bug 302076 has been marked as a duplicate of this bug. ***

Comment 11

[u88484]

*** Bug 302189 has been marked as a duplicate of this bug. ***

Comment 12

[Ben Goodger (use ben at mozilla dot org for email)]

Fixed.