299711 - Request for searchplugin update for Finnish Firefox 1.0+

Status: RESOLVED FIXED

(Mozilla Localizations :: Other, defect)

Description

[Ville Pohjanheimo (inactive)]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; fi-FI; rv:1.7.8) Gecko/20050610 Firefox/1.0.4 (Debian package 1.0.4-3)
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; fi-FI; rv:1.7.8) Gecko/20050610 Firefox/1.0.4 (Debian package 1.0.4-3)

There are two searchplugins in Finnish Firefox that would need updating. 

The auction searchplugins filename needs to be changed from huutonet.* to
huuto.* as a plugin by the latter name has after Firefox 1.0's release been
submitted to mycroft and there's no point having double entries there (my entry
didn't get submitted for some reason).

And more significantly: I'd like to replace the current online bookstore
searchplugin that's in the Finnish localization of Firefox.

The current search suomalainenkk.src (for site http://www.suomalainen.com) is no
good. I'd replace it with a search for http://www.bookplus.fi which is the
largest online bookstore in Finland and also has a much more searchplugin
friendly interface.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Ville Pohjanheimo (inactive)]

Attachment: Search plugin for bookplus.fi

Here's a working searchplugin for http://www.bookplus.fi in case someone wants
to see it.

Comment 2

[Axel Hecht]

Comment on attachment 188297 [details]
Search plugin for bookplus.fi

This plugin needs work.
The update part is broken copy-and-paste, and I'm
not confident about the description. The charset looks ok.

Comment 3

[Ville Pohjanheimo (inactive)]

The update is broken as I'm not going to submit it to mycroft until I get
approval to include it into Firefox (FI) with used filename etc. It will be OK
if I get to OK.

The description is fine for a Finnish speaker.

Comment 4

[Axel Hecht]

In general, I'm fine with these changes. I suggest getting the searchplugin on 
mycroft (with fixed update info), or to remove the update info until it is.

Comment 5

[Ville Pohjanheimo (inactive)]

Now both search plugins have been added and updated in mycroft. Bookplus.fi
should now be in the state Alex suggested.

Please approve to add to CVS.

Comment 6

[Ville Pohjanheimo (inactive)]

Attachment: The updated searchplugin

This is the up to date version of the bookplus searchplugin which has also been
submitted to mycroft.

This searchplugin should replace the practically broken suomalainenkk.src in
Finnish l10n of FF. The other change this bug requests is to rename
huutonet.src to huuto.src as the latter has already been submitted to mycroft.

Comment 7

[Rafael Ebron (:rebron)]

jst, what do you think on choices for search engines (policy vs. technical
question)?  

Essentially replace:
http://www.suomalainen.com/sk/

with:
http://www.bookplus.fi/main.php

Comment 8

[Johnny Stenback (:jst)]

Hard for me to say. I know suomalainen.com is a big book store in Finland
(probably the biggest, at least it was before I moved away), but bookplus.fi is
bi-lingual, which would serve a bigger audience in Finland, which is bi-lingual
n' all :)

Comment 9

[Ville Pohjanheimo (inactive)]

I originally chose Suomalainen as the searchplugin bookstore for the Finnish
Firefox as I didn't know any other that would have an online site too.

Suomalainen might have the most extensive chain of stores in Finland and be the
largest in that sense, but Bookplus on the other hand has the largest selection
of books.

Comment 10

[Johnny Stenback (:jst)]

Sounds like a pretty easy choice then, better selection *and* it's bi-lingual.

Comment 11

[Axel Hecht [:Pike]]

Comment on attachment 194417 [details]
The updated searchplugin

based on jst's comments, approving this one

Comment 12

[Axel Hecht [:Pike]]

... we still need to figure out the updateURL stuff, though. We'll have a separate
bug for that.

Comment 13

[Ville Pohjanheimo (inactive)]

Committed the changes.