299723 - [FIXr]Table attribute RULES doesn't seem to recognize "none" and other values work strangely

Status: VERIFIED FIXED

(Core :: Layout: Tables, defect, P1)

Description

[SZUCS Gábor]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050531 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050531 Firefox/1.0+

The simple example url works as expected in IE or Firefox 1.0, but produces an
unfortunate thin grid in Deer Park Alpha 1. 

I wonder if it's not a bug but a stricter interpretation of the HTML standard in
1.8, and if so, what is the correct solution?

1. If I use BORDER(>0), FRAME(above) and RULES(none), the frame "above" is
correct, but a thin grid around each cell is drawn (that violates RULES=none)

2. If I change RULES to groups or rows, the thin lines disappear, but the frame
seems to be overdrawn by two half-thick lines.

3. If I omit BORDER (RULES back to none), there's a thin frame "above" and no
other grid lines, but then I can't influence the line width.

Reproducible: Always

Steps to Reproduce:
Create a TABLE with BORDER="10px" RULES="none" FRAME="above" CELLSPACING="0" 
The latter two are not mandatory, just allows you to see more.
Actual Results:  
got a table with thin grids, contradictory with RULES=none.

Expected Results:  
draw a table without any lines except the thick line above the table.

Comment 1

[Martijn Wargers (dead)]

This regressed between 2005-04-28 and 2005-04-29:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2005-04-28+05%3A00%3A00&maxdate=2005-04-29+10%3A00%3A00&cvsroot=%2Fcvsroot
Probably a regression from fixing bug 290377.

Comment 2

[Martijn Wargers (dead)]

Attachment: testcase using frame="void" and rules="none"

Comment 3

[Boris Zbarsky [:bzbarsky]]

Actually, this is a regression from bug 155507.  The problem is that the table
attribute-mapping code is pretty silly; it maps in a computed style for cells
based on the table's border no matter what.  It used to be that the cell borders
got nixed later as part of collapsed border processing here, but that's not
happening for rules="none" anymore...

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 188342 [details] [diff] [review]
Fix

requesting 1.8b3 approval.  This is a quite safe fix for a regression in
rendering of tables with rules="none".

Comment 6

[Boris Zbarsky [:bzbarsky]]

Fixed.

Comment 7

[Gérard Talbot]

This bug is pretty much the same as bug 172213

Comment 8

[Boris Zbarsky [:bzbarsky]]

Gérard, I was just fixing a regression, but did this patch actually fix all the
issues in bug 172213?

Comment 9

[Gérard Talbot]

Boris, the way I see this: this bug was a duplicate of bug 172213. Either way,
as long as the problem is fixed, I don't really care :)

I'm using Firefox Deer Park alpha 1 build 20050707 under XP Pro SP2 and do not
see the fix when I try attachment 188325 [details] or attachment 101453 [details] or attachment
112626 [details]. I'll definately try with tomorrow's build.

Comment 10

[Boris Zbarsky [:bzbarsky]]

It wasn't quite a duplicate, since bug 172213 is present in Firefox 1.0, and
this bug as filed was not.  But yes, if you could test with tomorrow's builds,
that would be great!

Comment 11

[Gérard Talbot]

Excellent work, Boris. attachment 188325 [details], attachment 101453 [details] and attachment
112626 [details] all render expected results with Deer Park alpha 2 rv: 1.8b3 build
20050708 under XP Pro SP2. Thank you :)

Marking as VERIFIED