Closed
Bug 299748
Opened 19 years ago
Closed 19 years ago
On listbox, Sometimes, We cannot scroll the page to bottom by mouse wheel
Categories
(Core :: XUL, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla1.8beta3
People
(Reporter: masayuki, Assigned: masayuki)
References
()
Details
Attachments
(1 file, 5 obsolete files)
1.04 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
cbeard
:
approval1.8b3+
|
Details | Diff | Splinter Review |
If a listbox is scrolled to most bottom, we can scroll the page to bottom. But sometimes, it cannot scroll the page. Because following check is wrong. It is not checking the rounding by pixel. http://lxr.mozilla.org/seamonkey/source/content/events/src/nsEventStateManager.cpp#1724 1736 passToParent = (aScrollHorizontal ? 1737 (xPos + portRect.width >= scrolledSize.width) : 1738 (yPos + portRect.height >= scrolledSize.height)); On Win2k, In https://bugzilla.mozilla.org/query.cgi, I can reproduce this problem on the "Product", "Target" and "where one or more of the following changed".
Assignee | ||
Comment 1•19 years ago
|
||
Attachment #188332 -
Flags: superreview?(roc)
Attachment #188332 -
Flags: review?(roc)
Assignee | ||
Updated•19 years ago
|
Attachment #188332 -
Flags: superreview?(roc)
Attachment #188332 -
Flags: review?(roc)
Assignee | ||
Comment 2•19 years ago
|
||
Attachment #188332 -
Attachment is obsolete: true
Attachment #188335 -
Flags: superreview?(roc)
Attachment #188335 -
Flags: review?(roc)
Assignee | ||
Updated•19 years ago
|
Attachment #188335 -
Flags: superreview?(roc)
Attachment #188335 -
Flags: review?(roc)
Assignee | ||
Comment 3•19 years ago
|
||
Attachment #188335 -
Attachment is obsolete: true
Attachment #188336 -
Flags: superreview?(roc)
Attachment #188336 -
Flags: review?(roc)
Assignee | ||
Updated•19 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P2
Summary: On listbox, Sometimes, We cannot scroll the page to bottom → On listbox, Sometimes, We cannot scroll the page to bottom by mouse wheel
Target Milestone: --- → mozilla1.8beta3
I think it would be clearer for CanScroll to take parameters PRBool aHorizontal, PRBool aForward. Can you rework the patch to do that?
Assignee | ||
Updated•19 years ago
|
Attachment #188336 -
Flags: superreview?(roc)
Attachment #188336 -
Flags: review?(roc)
Attachment #188336 -
Flags: review-
Assignee | ||
Comment 5•19 years ago
|
||
Attachment #188336 -
Attachment is obsolete: true
Attachment #188425 -
Flags: superreview?(roc)
Attachment #188425 -
Flags: review?(roc)
Comment on attachment 188425 [details] [diff] [review] Patch rv2.0 + nsIDeviceContext *dev; + float t2p; + float p2t; + + mViewManager->GetDeviceContext(dev); + t2p = dev->AppUnitsToDevUnits(); + p2t = dev->DevUnitsToAppUnits(); + + NS_RELEASE(dev); Looks good, but make this an nsCOMPtr<nsIDeviceContext>, use getter_Addrefs and you don't need the NS_RELEASE.
Attachment #188425 -
Flags: superreview?(roc)
Attachment #188425 -
Flags: superreview+
Attachment #188425 -
Flags: review?(roc)
Attachment #188425 -
Flags: review+
Assignee | ||
Comment 7•19 years ago
|
||
The risk is low.
Attachment #188425 -
Attachment is obsolete: true
Attachment #188521 -
Flags: superreview+
Attachment #188521 -
Flags: review+
Attachment #188521 -
Flags: approval1.8b3?
Updated•19 years ago
|
Attachment #188521 -
Flags: approval1.8b3? → approval1.8b3+
Assignee | ||
Comment 8•19 years ago
|
||
checked-in. -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Comment 9•19 years ago
|
||
Do we need to bump the IID for the nsIScrollableView interface?
Comment 10•19 years ago
|
||
Yes, we do. Reopening until that happens... That should probably block 1.8b3.
Status: RESOLVED → REOPENED
Flags: blocking1.8b3?
Resolution: FIXED → ---
Assignee | ||
Comment 11•19 years ago
|
||
Attachment #188521 -
Attachment is obsolete: true
Attachment #188689 -
Flags: superreview?(roc)
Attachment #188689 -
Flags: review?(roc)
Assignee | ||
Updated•19 years ago
|
Status: REOPENED → ASSIGNED
Updated•19 years ago
|
Flags: blocking1.8b3? → blocking1.8b3+
Assignee | ||
Comment 12•19 years ago
|
||
Comment on attachment 188689 [details] [diff] [review] Changing the IID Boris: Could you review it?
Attachment #188689 -
Flags: superreview?(roc)
Attachment #188689 -
Flags: superreview?(bzbarsky)
Attachment #188689 -
Flags: review?(roc)
Attachment #188689 -
Flags: review?(bzbarsky)
Updated•19 years ago
|
Attachment #188689 -
Flags: superreview?(bzbarsky)
Attachment #188689 -
Flags: superreview+
Attachment #188689 -
Flags: review?(bzbarsky)
Attachment #188689 -
Flags: review+
Assignee | ||
Comment 13•19 years ago
|
||
Comment on attachment 188689 [details] [diff] [review] Changing the IID The risk is NONE. This is changing only IID of nsIScrollableView. This is final blocker bug of 1.8b3.
Attachment #188689 -
Flags: approval1.8b3?
Updated•19 years ago
|
Attachment #188689 -
Flags: approval1.8b3? → approval1.8b3+
Comment 14•19 years ago
|
||
let's get this landed asap for 1.8b3
Assignee | ||
Comment 15•19 years ago
|
||
checken-in. thanks.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago → 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•