Closed Bug 299762 Opened 19 years ago Closed 19 years ago

date attributes in calIICSService should be null when not valid

Categories

(Calendar :: Internal Components, defect)

Product:
Calendar
Component:
Internal Components
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mvl, Assigned: mvl)

Details

Attachments

(1 file, 1 obsolete file)

patch v2 (-w)
3.48 KB, patch
shaver
: first-review+
Details | Diff | Splinter Review 
The date attributes in calIICSService return an invalid calIDateTime is the date
isn't set. It should return null.
Attached patch patch (obsolete) — — Splinter Review 
patch returns nsnull on invalid dates. (and moves some addrefs, to not crash)
Assignee: shaver → mvl
Status: NEW → ASSIGNED
Attachment #188358 - Flags: first-review?(shaver)
Comment on attachment 188358 [details] [diff] [review]
patch

How about just setting *dtp to null and returning early if there's no prop? 
Then you can outdent the main part of the method.
Attached patch patch v2 (-w) — — Splinter Review 
Ok, this patch does that (diff -w for readability)
Attachment #188358 - Attachment is obsolete: true
Attachment #188367 - Flags: first-review?(shaver)
Comment on attachment 188367 [details] [diff] [review]
patch v2 (-w)

Gorgeous. r=shaver
Attachment #188367 - Flags: first-review?(shaver) → first-review+
Attachment #188358 - Flags: first-review?(shaver)
patch was checked in some time ago
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: