crufty with/eval event handler definition does not work

VERIFIED FIXED

Status

()

Core
JavaScript Engine
VERIFIED FIXED
13 years ago
12 years ago

People

(Reporter: brendan, Assigned: brendan)

Tracking

({js1.5})

Trunk
js1.5
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(URL)

(Assignee)

Description

13 years ago
This once worked, or so it says.  More when I have time to debug.

/be
(Assignee)

Updated

13 years ago
Assignee: general → brendan
(Assignee)

Updated

13 years ago
Depends on: 300008
(Assignee)

Comment 1

13 years ago
Fixed by the patch for bug 300008.  Apologies for my earlier security bugfix
attempts breaking the test URL and DHTML based on it.

I still say that the use of with and eval in that example is bad.  Suggestions
on how to get that bad example revised and corrected welcome.

/be
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED

Comment 2

13 years ago
Many thanks for fixing.

When will this fix be available to download?

Take Care

Dave
(In reply to comment #2)
> When will this fix be available to download?

Any builds which include the fix checked-in at 2005-07-08 16:26. Todays builds
will work.
Verified with Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b3) Gecko/20050710
Firefox/1.0+
Status: RESOLVED → VERIFIED

Comment 5

12 years ago
Ok - so this is fixed.

When it be released to the general public and on a Windows environment 
specifically in Firefox

Many Thanks

Dave
(Assignee)

Comment 6

12 years ago
(In reply to comment #5)
> When it be released to the general public and on a Windows environment 
> specifically in Firefox

Firefox 1.1.

This is not the best place to ask such questions, but since you did, perhaps you
can give a suggestion in response to my comment 1 request: "Suggestions on how
to get that bad example revised and corrected welcome."

/be

Comment 7

12 years ago
Ok..
Well - as for fixing the 'bad example' - the best place to do that would be to 
make a suggestion to Matt Kruse on his forum.  The code may be bad (was 
apparently a fix for a previous version of Netscape) but it did work prior to 
Firefox V1.0.3
Though I think that by changing the code it will break compatibility for older 
browsers. The code is there if you have any suggestions to him and he is pretty 
reasonable.

I'm surprized that a question re the availability of a fix is classed as 
inappropriate. Where else should I ask but from the developer who fixed the 
issue.  I'm just a web page developer who reported an issue to try and help FF 
compatibility. 

Many Thanks
Dave
(Assignee)

Comment 8

12 years ago
(In reply to comment #7)
> Ok..
> Well - as for fixing the 'bad example' - the best place to do that would be to 
> make a suggestion to Matt Kruse on his forum.

Thanks, I'll give that a try.

> The code may be bad (was 
> apparently a fix for a previous version of Netscape) but it did work prior to 
> Firefox V1.0.3

Oh, I forgot -- this bug is fixed in Firefox 1.0.5 too.  Good news.

> I'm surprized that a question re the availability of a fix is classed as 
> inappropriate. Where else should I ask but from the developer who fixed the 
> issue.  I'm just a web page developer who reported an issue to try and help FF 
> compatibility. 

This is bugzilla, it's really for testers and developers to work efficiently on
fixing bugs.  It's not about releases so much, or user support.  But hey, you
asked and I answered, so it's not a big deal ;-).

/be

Comment 9

12 years ago
Many for all of the help.

My clients downloaded V1.0.5 today and the draggable frames work once more.

Again.. My thanks to the teams.
Dave

Comment 10

12 years ago
test covered in bug 300008.
Flags: testcase+
You need to log in before you can comment on or make changes to this bug.