Closed
Bug 299812
Opened 20 years ago
Closed 19 years ago
Changing (Win32) Readme.txt for SeaMonkey
Categories
(SeaMonkey :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: cbook, Assigned: kairo)
References
Details
Attachments
(1 file)
30.58 KB,
patch
|
neil
:
review+
neil
:
superreview+
asa
:
approval1.8b4+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050705 SeaMonkey/1.0a Mnenhy/0.7.2.10005
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050705 SeaMonkey/1.0a Mnenhy/0.7.2.10005
We need to Change/Modify the Readme.txt (seamonkey\readme.txt) for SeaMonkey,
because of the Mozilla Content and Links in the current readme.txt
http://lxr.mozilla.org/seamonkey/source/README.txt
Reproducible: Always
Steps to Reproduce:
Reporter | ||
Updated•20 years ago
|
Assignee: general → kairo
Version: unspecified → Trunk
Assignee | ||
Comment 1•20 years ago
|
||
(In reply to comment #0)
> http://lxr.mozilla.org/seamonkey/source/README.txt
Yes, I fear it's exactly that file, which is the main README in the Mozilla
tree, and I'd rather not change that file at this position. We probably need to
create a rebranded copy of that file (in a suite/ subdirectory?) and use that
one instead.
Assignee | ||
Comment 2•20 years ago
|
||
Neil:
As I already layed out on IRC, this file is only shipped with Windows, Linux has
a different one (we ship the README also with zip builds on Windows, we don't
ship any README for Linux .tar.gz/bz2 builds, only installer AFAIK).
So, we have different README files for different platforms, it might be good to
have them in parallel somewhere in suite/ - where do you think we should put them?
Should we do
suite/README.win.txt
suite/README.unix
etc.
or some subdir structure?
Assignee | ||
Comment 3•20 years ago
|
||
Neil:
From what I see, it might be best to place our READMEs in the directory
suite/locales/en-US/installer/
which means they even can get localized by people in the future...
I propose a naming the files
README-win.txt
README-os2.txt
README-unix
and get them packaged/installed as README.txt/README, as usual on those platforms.
Comment 4•20 years ago
|
||
Please put them in subdirectories os2/README.txt win/README.txt etc so that they
can be $(INSTALL)ed without renaming them.
Assignee | ||
Comment 5•20 years ago
|
||
(In reply to comment #4)
> Please put them in subdirectories os2/README.txt win/README.txt etc so that they
> can be $(INSTALL)ed without renaming them.
OK, good. makes sense.
In that case, I'll try to do that for the windows README early next week.
Assignee | ||
Comment 6•20 years ago
|
||
OK, this patch moves all SeaMonkey READMEs over to
suite/locales/en-US/installer/ and adds them into dist/bin instead of the old
ones if MOZ_SUITE is set (i.e. _only_ for SeaMonkey). I also did a bit of an
overhaul of those READMEs (rebranding, specializing for all platforms).
We should make unix installer use that one and remove the extra copy in its own
directory once those have landed.
Attachment #189443 -
Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #189443 -
Flags: review?(neil.parkwaycc.co.uk)
Updated•20 years ago
|
Attachment #189443 -
Flags: superreview?(neil.parkwaycc.co.uk) → superreview+
Assignee | ||
Comment 7•20 years ago
|
||
FYI, it's intentional that the unix README is not wrapped:
<ajschult> see bug 237275 for README wrapping-foo
Apparently, only the unix variant of our installer shows the README to the user,
so it's only an issue there.
Comment 8•19 years ago
|
||
*** Bug 302128 has been marked as a duplicate of this bug. ***
Updated•19 years ago
|
Attachment #189443 -
Flags: review?(neil.parkwaycc.co.uk) → review+
Assignee | ||
Comment 9•19 years ago
|
||
Comment on attachment 189443 [details] [diff] [review]
patch v1: move all SeaMonkey READMEs over to suite/
requesting approval - this is a SeaMonkey-only change affecting only README
files in suite packages
Attachment #189443 -
Flags: approval1.8b4?
Updated•19 years ago
|
Attachment #189443 -
Flags: approval1.8b4? → approval1.8b4+
Assignee | ||
Comment 10•19 years ago
|
||
Checked in that patch. We might need followups for using/including those files
in the installers one time...
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•