299868 - 3 U/S issues for dpa2

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

- wizard UI in weird state because of buttons enabled at inappropriate moments 
- partial download is not resumed across browser sessions
- restart now button should read "Restart <appname> Now" so users aren't fooled
into thinking this will restart their OS since Windows randomly poses similar
dialogs. 

Patch for issue 1 is to ensure each wizard page sets the buttons to the correct
enabled state on page show, regardless of the state the buttons were left in by
the previous page, since different wizard orders can mean that buttons are not
guaranteed to be in a good state if the assumed previous page was not visited. 

Issue 2 is to special case the STATE_DOWNLOADING case in the
postUpdateProcessing function...

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch

Comment 2

[Darin Fisher]

Comment on attachment 188454 [details] [diff] [review]
patch

looks good, r=darin

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 188454 [details] [diff] [review]
patch

Seeking approval to land... would like to get this in tonight... fixes a few
known major issues with update wizard UI.

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

landed.