javascript error "strings has no properties" when opening help menu in bookmark manager

VERIFIED FIXED in Firefox1.5

Status

()

Firefox
Bookmarks & History
VERIFIED FIXED
13 years ago
12 years ago

People

(Reporter: whimboo, Assigned: whimboo)

Tracking

(Blocks: 1 bug, {regression})

Trunk
Firefox1.5
regression
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Assignee)

Description

13 years ago
Opening the help menu of the bookmark manager following js error is thrown:

Error: strings has no properties
Source File: chrome://browser/content/utilityOverlay.js
Line: 430
(Assignee)

Comment 1

13 years ago
Created attachment 188466 [details] [diff] [review]
patch adds missed stringbundleset to bookmarksManager.xul
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Attachment #188466 - Flags: review?(benjamin)
The stringbundle should be added at
http://lxr.mozilla.org/mozilla/source/browser/base/content/baseMenuOverlay.xul#130
, otherwise it won't work on Mac or in the DOM Inspector.

Updated

13 years ago
Attachment #188466 - Flags: review?(benjamin) → review+
Comment on attachment 188466 [details] [diff] [review]
patch adds missed stringbundleset to bookmarksManager.xul

comment 1 is right, minusing.
Attachment #188466 - Flags: review+ → review-
(Assignee)

Comment 4

13 years ago
Created attachment 188554 [details] [diff] [review]
patch added the stringbundle to baseMenuOverlay.xul

Thank you Gavin. I didn't saw it on my Linux build. DOMi was just working
correctly but I don't have a Mac.
Attachment #188554 - Flags: review?(benjamin)
(Assignee)

Comment 5

13 years ago
Created attachment 188555 [details] [diff] [review]
patch added the stringbundle to baseMenuOverlay.xul

Thank you Gavin. I didn't saw it on my Linux build. DOMi was just working
correctly but I don't have a Mac.
Attachment #188466 - Attachment is obsolete: true
Attachment #188555 - Flags: review?(benjamin)
(Assignee)

Updated

13 years ago
Attachment #188554 - Attachment is obsolete: true
Attachment #188554 - Flags: review?(benjamin)

Updated

13 years ago
Attachment #188555 - Flags: review?(benjamin) → review+
(Assignee)

Updated

13 years ago
Attachment #188555 - Flags: approval-aviary1.1a2?

Updated

13 years ago
Attachment #188555 - Flags: approval-aviary1.1a2? → approval-aviary1.1a2+
(Assignee)

Updated

13 years ago
Whiteboard: [checkin needed]
(Assignee)

Comment 6

13 years ago
Fix checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
(Assignee)

Updated

13 years ago
Target Milestone: --- → Firefox1.1
(Assignee)

Updated

13 years ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 7

13 years ago
Created attachment 188863 [details] [diff] [review]
Patch removes bundle_browser in browser-sets.inc

The bundle was already defined in browser-sets.inc which is also included by
browser.xul. We have to remove it there.
Attachment #188863 - Flags: review?(benjamin)

Updated

13 years ago
Attachment #188863 - Flags: review?(benjamin) → review+
(Assignee)

Updated

13 years ago
Attachment #188863 - Flags: approval-aviary1.1a2?

Updated

12 years ago
Attachment #188863 - Flags: approval-aviary1.1a2? → approval1.8b4+
Checking in browser-sets.inc;
/cvsroot/mozilla/browser/base/content/browser-sets.inc,v  <--  browser-sets.inc
new revision: 1.50; previous revision: 1.49
done
 
Status: REOPENED → RESOLVED
Last Resolved: 13 years ago12 years ago
Keywords: regression
Resolution: --- → FIXED
(Assignee)

Updated

12 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.