fix nsIMimeEmitter to use proper case

RESOLVED FIXED in Thunderbird 3.0rc1

Status

--
minor
RESOLVED FIXED
14 years ago
10 years ago

People

(Reporter: timeless, Assigned: mkmelin)

Tracking

Trunk
Thunderbird 3.0rc1

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

14 years ago
this interface is only used internally so now is the time to fix it.

Updated

10 years ago
QA Contact: mime
Product: Core → MailNews Core
(Assignee)

Comment 1

10 years ago
Created attachment 342616 [details] [diff] [review]
proposed fix

Change to lowerCamelCase and clean up whitespace/comments. 
Also the same for nsIMsgQuote.
Assignee: timeless → mkmelin+mozilla
Status: NEW → ASSIGNED
Attachment #342616 - Flags: superreview?(bienvenu)
Attachment #342616 - Flags: review?(bienvenu)

Comment 2

10 years ago
Comment on attachment 342616 [details] [diff] [review]
proposed fix

thanks for doing this.

can't this be an attribute?

+    void setOutputListener(in nsIStreamListener listener);
 
     //Get the output listener to allow access to it from mime
-    nsIStreamListener    GetOutputListener();
+    nsIStreamListener getOutputListener();

have you checked there are no js callers that would be affected by the case change?
(Assignee)

Comment 3

10 years ago
Created attachment 342622 [details] [diff] [review]
proposed fix, v2

Yes, looks like it can be an attribute. 
AFAICT, there are no js callers at all for this interface.
Attachment #342616 - Attachment is obsolete: true
Attachment #342622 - Flags: superreview?(bienvenu)
Attachment #342622 - Flags: review?(bienvenu)
Attachment #342616 - Flags: superreview?(bienvenu)
Attachment #342616 - Flags: review?(bienvenu)

Comment 4

10 years ago
Comment on attachment 342622 [details] [diff] [review]
proposed fix, v2

ok, thx, Magnus.
Attachment #342622 - Flags: superreview?(bienvenu)
Attachment #342622 - Flags: superreview+
Attachment #342622 - Flags: review?(bienvenu)
Attachment #342622 - Flags: review+
(Assignee)

Comment 5

10 years ago
changeset:   579:f6239bbf466f
http://hg.mozilla.org/comm-central/rev/f6239bbf466f

->FIXED
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0rc1
You need to log in before you can comment on or make changes to this bug.