Closed Bug 299932 Opened 16 years ago Closed 13 years ago

fix nsIMimeEmitter to use proper case

Categories

(MailNews Core :: MIME, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0rc1

People

(Reporter: timeless, Assigned: mkmelin)

References

()

Details

Attachments

(1 file, 1 obsolete file)

this interface is only used internally so now is the time to fix it.
QA Contact: mime
Product: Core → MailNews Core
Attached patch proposed fix (obsolete) — Splinter Review
Change to lowerCamelCase and clean up whitespace/comments. 
Also the same for nsIMsgQuote.
Assignee: timeless → mkmelin+mozilla
Status: NEW → ASSIGNED
Attachment #342616 - Flags: superreview?(bienvenu)
Attachment #342616 - Flags: review?(bienvenu)
Comment on attachment 342616 [details] [diff] [review]
proposed fix

thanks for doing this.

can't this be an attribute?

+    void setOutputListener(in nsIStreamListener listener);
 
     //Get the output listener to allow access to it from mime
-    nsIStreamListener    GetOutputListener();
+    nsIStreamListener getOutputListener();

have you checked there are no js callers that would be affected by the case change?
Attached patch proposed fix, v2Splinter Review
Yes, looks like it can be an attribute. 
AFAICT, there are no js callers at all for this interface.
Attachment #342616 - Attachment is obsolete: true
Attachment #342622 - Flags: superreview?(bienvenu)
Attachment #342622 - Flags: review?(bienvenu)
Attachment #342616 - Flags: superreview?(bienvenu)
Attachment #342616 - Flags: review?(bienvenu)
Comment on attachment 342622 [details] [diff] [review]
proposed fix, v2

ok, thx, Magnus.
Attachment #342622 - Flags: superreview?(bienvenu)
Attachment #342622 - Flags: superreview+
Attachment #342622 - Flags: review?(bienvenu)
Attachment #342622 - Flags: review+
changeset:   579:f6239bbf466f
http://hg.mozilla.org/comm-central/rev/f6239bbf466f

->FIXED
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0rc1
You need to log in before you can comment on or make changes to this bug.