299939 - make -C suite-opt/xpinstall/packager installer does not make a working installer

Status: RESOLVED INVALID

(SeaMonkey :: Installer, defect)

Description

[Timothy B. Anderson (Tails)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050707 SeaMonkey/1.0a
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050707 SeaMonkey/1.0a

When running this command it finishes fine.  I will include a screen shot of the
Properties of the C:\Program Files\mozilla.org\SeaMonkey folder to show how many
folders and files are created.

Reproducible: Always

Steps to Reproduce:
1. run make -C suite-opt/xpinsall/packer installer

Actual Results:  
1. 17.3MB seamonkey-1.0a.en-US.win32.installer.exe
2. no desktop icon
3. no guick launch icon
4. no SeaMonky program group

Expected Results:  
12 MB seamonkey-1.0a.en-US.win32.installer.exe like on the mirrors and installed
2 to 4.

Comment 1

[Timothy B. Anderson (Tails)]

Attachment: Screen Shot of Folders & Files created

Comment 2

[Adrian Buckley]

> Steps to Reproduce:
> 1. run make -C suite-opt/xpinsall/packer installer
> 

Try using:
<MOZ_SRC>/xpinstall/wizard/<OS>/builder/build.pl -distPath "<MOZ_OBJDIR>/dist"
-objDir "<MOZ_OBJDIR>"

instead, substituting <MOZ_SRC> <MOZ_OBJDIR> and <OS> as appropriate.

Comment 3

[Benjamin Smedberg]

Adrian, that's ridiculous.

Timothy, did you build an optimize non-debug build?

Comment 4

[Timothy B. Anderson (Tails)]

Here is my .mozconfig setup:

CC=gcc
CXX=g++
CPP=cpp
AS=as
LD=ld
ac_add_options --disable-accessibility
ac_add_options --disable-activex
mk_add_options MOZ_CO_PROJECT=suite
ac_add_options --enable-application=suite
mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/suite-opt
ac_add_options --enable-optimize
ac_add_options --disable-debug

Comment 5

[Adrian Buckley]

(In reply to comment #3)
> Adrian, that's ridiculous.

To quote the following page:
http://www.mozilla.org/build/distribution.html

#  To create a win32 installer, you need the following:

    * ActiveState or cygwin Perl
    * Msvcrt.dll and msvcirt.dll These files must be copied to the
%MOZ_SRC%\redist\microsoft\system directory on your build system. Without these
files, the build will not fail, but the package you create will have problems on
rare Windows systems that don't already have the files installed (mostly Win95)
as described in bug 27601. The system files can be found at:
http://www.freewarefiles.com/category/library.htm

To build the win32 installer, change to the xpinstall builder directory and run
the perl script. This creates the file mozilla-win32-installer.exe in
mozilla\dist\install.

cd mozilla\xpinstall\wizard\windows\builder
perl build.pl

Comment 6

[Timothy B. Anderson (Tails)]

(In reply to comment #3)
> Adrian, that's ridiculous.
> 
> Timothy, did you build an optimize non-debug build?

It is.  I get this from doing it:

 Error: /cygdrive/c/mozilla/suite-opt/dist/inst_gre/../install/nsztool.exe /cygd
rive/c/mozilla/suite-opt/dist/inst_gre/GREUninstall.exe /cygdrive/c/mozilla/suit
e-opt/dist/inst_gre/uninstall/*.*

 Error: perl "/cygdrive/c/mozilla/xpinstall/packager/win_gre/makeall.pl" -objDir
 "/cygdrive/c/mozilla/suite-opt" -stagePath "/cygdrive/c/mozilla/suite-opt/stage
" -distPath "/cygdrive/c/mozilla/suite-opt/dist" -aurl ftp://not.supplied.invali
d -rurl ftp://not.supplied.invalid

 Error: perl makeall.pl -objDir "/cygdrive/c/mozilla/suite-opt" -stagePath "/cyg
drive/c/mozilla/suite-opt/stage" -distPath "/cygdrive/c/mozilla/suite-opt/dist"
-aurl ftp://not.supplied.invalid -rurl ftp://not.supplied.invalid

Comment 7

[Timothy B. Anderson (Tails)]

I found out that my .exe installs 19 Objects to C:\Program
Files\mozilla.org\SeaMonkey while the Clobber builds install 31 Objects.  Maybe
I am missing something somewhere to make it work?

Comment 8

[Benjamin Smedberg]

I did not notice: we do not support building the installer with a mingw build,
only msvc.