299984 - Change Firefox searchplugins entry (add goo and rakuten, remove ebay and dictionary)

Status: RESOLVED FIXED

(Mozilla Localizations :: ja / Japanese, defect)

Description

[dynamis (Tomoya ASAI)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; ja-JP; rv:1.7.8) Gecko/20050511
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; ja-JP; rv:1.7.8) Gecko/20050511

Japanese l10n would like to change Firefox searchplugins entry.

At this time: google, yahoo, amazondotcom, creativecommons, dictionary, eBay 	 
After cahnge: google, yahoo, amazon, rakuten, goo, creativecommons

eBay and dictionary.com don't have japanese site and we'll remove them.
goo is japanese famous search engine:
http://www.goo.ne.jp/
Rakuten-ichiba ('ichiba' means market) is japanese famous market place:
http://www.rakuten.co.jp/

And we want to specfy the order of searchplugins.
google, yahoo, amazon, rakuten, goo, creativecommons, respectively.

# I'm writtin this bug on behalf of mozilla-japan marketting staffs.

Reproducible: Always

Comment 1

[dynamis (Tomoya ASAI)]

Attachment: searchplugin for goo.ne.jp

Comment 2

[dynamis (Tomoya ASAI)]

Attachment: searchplugin logo for goo.ne.jp

Comment 3

[dynamis (Tomoya ASAI)]

Searchplugin for Rakuten is now preparing.
Marketting staffs are talking to Rakuten so far.

Comment 4

[dynamis (Tomoya ASAI)]

Attachment: searchplugin for rakuten (tentative)

This is not final plugin. Just for test now.
We'll update this not so far.

Comment 5

[dynamis (Tomoya ASAI)]

Attachment: searchplugin logo for rakuten (tentative)

Comment 6

[dynamis (Tomoya ASAI)]

Could you give us your approval, Rafael?
We are waiting your approval to add/remove searchplugins.

Comment 7

[Channy Yun [:channy]]

Dynamis, maybe you must report this bug in section of marketing > trademark
permissions of bugzilla. This is just for bug of localization ja locale. :)

Comment 8

[dynamis (Tomoya ASAI)]

I see, thanks Channy.

Comment 9

[dynamis (Tomoya ASAI)]

I confirmed where should I file a bug and answer is here.
# or anywhere elese, we just have to contact rebron.
So, I won't make another bug in another product/compornent about this.

Comment 10

[Rafael Ebron (:rebron)]

Getting approval is going to take some time.  

Comment 11

[dynamis (Tomoya ASAI)]

Attachment: searchplugin for rakuten

Updated searchplugin for rakuten (maybe final)

Comment 12

[dynamis (Tomoya ASAI)]

Attachment: searchplugin logo for rakuten

Updated logo image.

Comment 13

[Rafael Ebron (:rebron)]

Approved to remove ebay and dictionary.com
Waiting on approval for goo and rakuten.

Comment 14

[Axel Hecht]

(In reply to comment #13)
> Waiting on approval for goo and rakuten.

Who's responsible for that approval?

Comment 15

[dynamis (Tomoya ASAI)]

I heard that Mozilla Japan had already got approval about this changes.
Time limit is comming and unless you stop me before within 2 days, I'll add
searchplugins for goo/rakuten and put them in this order:
google, yahoo, amazon, rakuten, goo, creativecommons, respectively.

To make them in this order, I'll write in firefox-l10n.js:
+ pref("browser.search.order.3", "chrome://browser-region/locale/region.properties");
+ pref("browser.search.order.4", "chrome://browser-region/locale/region.properties");
+ pref("browser.search.order.5", "chrome://browser-region/locale/region.properties");
+ pref("browser.search.order.6", "chrome://browser-region/locale/region.properties");

and in region.properties:
+ browser.search.order.3			= Amazon.co.jp
+ browser.search.order.4			= \u697d\u5929\u5e02\u5834
+ browser.search.order.5			= goo \u30a6\u30a7\u30d6\u691c\u7d22
+ browser.search.order.6			= Creative Commons

# of cource, this code is already tested

Comment 16

[Rafael Ebron (:rebron)]

That's not true. This list hasn't been approved.

Comment 17

[Rafael Ebron (:rebron)]

rakuten and goo are approved to be checked-in. Please update the search plug-ins for the browser check. 

For this:
    update="http://www.mozilla-japan.org/jp/l10n/search/rakuten.src"
    updateIcon="http://www.mozilla-japan.org/jp/l10n/search/rakuten.gif"

Needs to go on to a secure url:
so, 
    update="https://addons.mozilla.org/searchplugins/updates/rakuten.src"
    updateIcon="https://addons.mozilla.org/searchplugins/updates/rakuten.gif"

Comment 18

[Rafael Ebron (:rebron)]

Attachment: Yahoo! Search

Replace current Yahoo plug-in

Comment 19

[Rafael Ebron (:rebron)]

Attachment: Yahoo!Search

Comment 20

[Rafael Ebron (:rebron)]

Attachment: Yahoo!search .gif

Comment 21

[Rafael Ebron (:rebron)]

Attachment: Yahoo! Auctions

replacement for eBay!

Comment 22

[Rafael Ebron (:rebron)]

Attachment: Yahoo! Auctions .gif

Comment 23

[Rafael Ebron (:rebron)]

Attachment: Yahoo! Shopping

Comment 24

[Rafael Ebron (:rebron)]

Attachment: Yahoo! Shopping .gif

Comment 25

[Rafael Ebron (:rebron)]

Suggested order is:
Yahoo
Google
goo
Rakuten
Yahoo!Shopping
Yahoo!Auctions
Amazon
Creative Commons

Comment 26

[Rafael Ebron (:rebron)]

sorry should be:
Yahoo!JAPAN, Google, Rakuten, goo, Yahoo! Shopping, Yahoo! Auction, Amazon.co.jp, Creative Commons

Comment 27

[dynamis (Tomoya ASAI)]

I checked-in your new searchplugins for Yahoo! but shouln't I translate the
words in the plugins?
  "Yahoo! Japan Search"
                ~~~~~~
  "Yahoo! Japan Auction Search"
                ~~~~~~~~~~~~~~
  "Yahoo! Japan Shopping Search"
                ~~~~~~~~~~~~~~~
I think it's better to translate them into Japanese for Japanese Users.
Especially about "auction" and "shoppping", not a few japanese users cannot
understand.

Yahoo! Japan use japanese for above underlined words in all over their site.
  "Search" is in japanese in their logo image too:
  http://i.yimg.jp/images/search/head_050825.gif
  Exception seems to be only their log image for shoppping/auction site:
  http://img.yahoo.co.jp/images/sh/jp_shop4.gif
  http://image.auctions.yahoo.co.jp/images/a4j.gif

Comment 28

[Rafael Ebron (:rebron)]

Yes please translate.

Comment 29

[Axel Hecht]

(In reply to comment #28)
> Yes please translate.

.src files are ASCII, I doubt that translation works in the UI, make sure
you check that.

Comment 30

[dynamis (Tomoya ASAI)]

> .src files are ASCII, I doubt that translation works in the UI, make sure
> you check that.
ASCII is just defaut charset.
We can specify charse as SHIFT_JIS with
  sourceTextEncoding="1"
All encordings are defined here:
http://lxr.mozilla.org/seamonkey/source/xpfe/components/search/src/nsInternetSearchService.cpp#3813

We already checked plugins can be translated and after the review for translated
name by mozilla-japan marketting staffs, I'll commit updated .src files and
region.properties.

Comment 31

[Axel Hecht]

No check-ins without approval, even the grace period is done.

Attach a patch, I'll get together with rebron and build/triage to see if we
take it or not.

Comment 32

[Rafael Ebron (:rebron)]

Attachment: Yahoo!

shortened the name

Comment 33

[Rafael Ebron (:rebron)]

Attachment: Yahoo! Shopping

shortened name

Comment 34

[Rafael Ebron (:rebron)]

Attachment: Yahoo! Auctions

shortened name

Comment 35

[Rafael Ebron (:rebron)]

region.properties needs to be changed as well to reflect the new names.

Updated plug-ins to shorten the name in the text box so what we see is:
Yahoo!
Yahoo! Shopping
Yahoo! Auctions

Comment 36

[dynamis (Tomoya ASAI)]

Attachment: Patch to change plugin names

This patch fix names of search engines.
# against current cvs, not against comment #35
# of cource already tested on latest nightly with updated langpack

We contacted marketting staffs of Japanes search engines and confirmed about
the name of their search plugins.
Then, goo and Yahoo! JAPAN required to change the name and this patch will
fit names to their request.

Yahoo! JAPAN's plugin name is not same as Rafael's but we must use names within
this patch just because they are the required name by Yahoo! JAPAN himself.

Comment 37

[Axel Hecht [:Pike]]

Comment on attachment 203373 [details] [diff] [review]
Patch to change plugin names

Please check this in ASAP, and note this in the bug.

There is one remaining blocker in ja/ja-JP-mac, the goo.src plugin updates from the web and not from addons. We need to fix that, sorry for catching this this late.

Comment 38

[dynamis (Tomoya ASAI)]

Attachment: updated goo.src

(In reply to comment #37)
> There is one remaining blocker in ja/ja-JP-mac, the goo.src plugin updates from
> the web and not from addons. We need to fix that, sorry for catching this this
> late.

This attachement is updated plugin for goo.

Comment 39

[dynamis (Tomoya ASAI)]

Attachment: updated goo.src with new tracking value

We may have to use this one, not previous one.

The plugin for goo may have to be updated one more time.
This plugin indicates that the search is via firefox 1.1 but it should be 1.5.
-<input name="from" value="Firefox11">
-<input name="PT" value="Firefox11">
+<input name="from" value="Firefox15">
+<input name="PT" value="Firefox15">
We are contacting and confirming about this with goo, and I'm not sure if the
value will be exactly "Firefox15" or a little different one.
That is, the value may be value="Firefox1.5" or ...

If you give us approval about this too now, not waiting the answer from goo,
it'll save both your and our time.
Thanks.

Comment 40

[dynamis (Tomoya ASAI)]

We got answer about tracking code from goo and previous attachment is OK.
I checked-in the new plugin for goo.

Now, all the change about japanese search plugins is done.
# -> RESOLVED FIXED

Thanks.