300006 - "cookies need value" error code when a query returns an empty result.

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Albert Ting]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041223 Firefox/1.0
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20041223 Firefox/1.0

With the latest tip, I'm seeing a cookies_need_value error code when a query
returns an empty list.  That's because Bugzilla::CGI::send_cookie is expecting a
value for the "-value" key, but buglist is sending an empty string.

I don't know what's the best way to fix it, but will enclose a simple patch that
worked for me. 

This is probably a show stopper for 2.20.  Apologies if this is a dup, couldn't
find a related ticket. 

Reproducible: Always

Steps to Reproduce:

Comment 1

[Albert Ting]

Attachment: suggested patch

Comment 2

[Marc Schumann [:Wurblzap]]

This is a regression of bug 268146.

Comment 3

[Marc Schumann [:Wurblzap]]

Your patch is the right way to go, and it fixes the issue at hand.

Can you check whether there are other places similarly broken? I found one:
o In a bug list, press "Change Columns"
o Uncheck all check marks
o Press "Change Columns"

If you don't find the time to validate (and, if necessary, fix) other
send_cookie callsites, then please request review on your patch from me, and
I'll set r+ and fix the other places myself in other bugs.

Comment 4

[Marc Schumann [:Wurblzap]]

Attachment: Patch for HEAD and branch

I checked the other places.

What'll happen if you remove all checkmarks in colchange.cgi now is that you'll
get your column list reset to the bz default.

Comment 5

[Albert Ting]

> I checked the other places.

You beat me to the punch.  But yup, I didn't see any other send_cookie problems.

> What'll happen if you remove all checkmarks in colchange.cgi now is that you'll
> get your column list reset to the bz default.

That's what I'm seeing as well.

Comment 6

[:glob ✱]

Comment on attachment 188598 [details] [diff] [review]
Patch for HEAD and branch

r=glob

>     my $list = join(" ", @collist);
>     my $urlbase = Param("urlbase");
> 
>-    $cgi->send_cookie(-name => 'COLUMNLIST',
>-                      -value => $list,
>-                      -expires => 'Fri, 01-Jan-2038 00:00:00 GMT');
>+    if ($list) {
>+        $cgi->send_cookie(-name => 'COLUMNLIST',

nit:  i think this would be clearer as

  if (@collist) {

Comment 7

[Max Kanat-Alexander]

I checked in this patch so that we can release tonight.

Tip:

Checking in buglist.cgi;
/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v  <--  buglist.cgi
new revision: 1.299; previous revision: 1.298
done
Checking in colchange.cgi;
/cvsroot/mozilla/webtools/bugzilla/colchange.cgi,v  <--  colchange.cgi
new revision: 1.49; previous revision: 1.48
done

2.18: 

Checking in buglist.cgi;
/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v  <--  buglist.cgi
new revision: 1.255.2.10; previous revision: 1.255.2.9
done
Checking in colchange.cgi;
/cvsroot/mozilla/webtools/bugzilla/colchange.cgi,v  <--  colchange.cgi
new revision: 1.41.2.4; previous revision: 1.41.2.3
done