Closed Bug 300023 Opened 19 years ago Closed 19 years ago

[FIXr]JS component loader should clear globals when it unroots them

Categories

(Core :: XPConnect, defect, P2)

Product:
Core
Component:
XPConnect
Platform:
x86
Linux
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.8beta3

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Details

Attachments

(1 file)

Proposed patch
1.83 KB, patch
shaver
: review+
brendan
: superreview+
asa
: approval1.8b3+
Details | Diff | Splinter Review 
See comments in bug 296987 starting with bug 296987 comment 8 (esp. bug 296987
comment 12).
Attached patch Proposed patch — — Splinter Review 

        Attachment #188604 -
        Flags: superreview?(brendan)

        Attachment #188604 -
        Flags: review?(shaver)

    
  
Priority: -- → P2
Summary: JS component loader should clear globals when it unroots them → [FIX]JS component loader should clear globals when it unroots them
Target Milestone: --- → mozilla1.9alpha

    
    

    
  
Comment on attachment 188604 [details] [diff] [review]
Proposed patch

I was thinking of this at dinner, actually. =)

r=shaver, if you remove the :: prefix that's counter to house style.

        Attachment #188604 -
        Flags: review?(shaver) → review+

    
    

    
  
Comment on attachment 188604 [details] [diff] [review]
Proposed patch

Yay!

/be

        Attachment #188604 -
        Flags: superreview?(brendan) → superreview+

    
    

    
  
Comment on attachment 188604 [details] [diff] [review]
Proposed patch

This should be pretty safe and prevents some shutdown leaks...

        Attachment #188604 -
        Flags: approval1.8b3?

    
  
Summary: [FIX]JS component loader should clear globals when it unroots them → [FIXr]JS component loader should clear globals when it unroots them
Target Milestone: mozilla1.9alpha → mozilla1.8beta3

    
    

    
  
Comment on attachment 188604 [details] [diff] [review]
Proposed patch

Approval question: has this been tested with Firefox?

    
    

    
  
I tested that firefox starts up and loads pages, yes (I was doing the leak
testing that showed this problem in firefox in the first place).

    
  

        Attachment #188604 -
        Flags: approval1.8b3? → approval1.8b3+

    
    

    
  
Checked in.  Firefox startup leaks on balsa dropped some, as expected.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: