300038 - [Mac] "Check for Updates to your extensions" button not functional

Status: RESOLVED WORKSFORME

(Toolkit :: Add-ons Manager, defect)

Description

[Marcia Knous [:marcia]]

Seen using Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.9)
Gecko/20050707 Firefox/1.0.5

STR:

1.  Install a few extensions that have older versions.
2.  Click on the check for updates button in extension manager.
3.  Dialog launches with no updates found, but there are updates.
4.  Navigate to preferences and check the extensions button in software update -
the dialog launches and updates are found.

tested on today's windows build and i did not see this issue.

Comment 1

[Marcia Knous [:marcia]]

Josh and I confirmed this works in 1.0.4, so now we need to hunt down the
regression window.

Comment 2

[Marcia Knous [:marcia]]

Nominating, assigning to josh

Comment 3

[Josh Aas]

I can't reproduce this with the 1.0.5 release candidate.

Comment 4

[Jay Patel [:jay]]

For the record, this is not a problem on Windows.  I was able to check for
updates  without issue in the extension manager with Mozilla/5.0 (Windows; U;
Windows NT 5.1; en-US; rv:1.7.9) Gecko/20050707 Firefox/1.0.5.

However, I noticed that sometimes a single extension is selected and if you
click the update button, it will only check for that particular extensions.  I
had to ctrl-click on the highlighted extension so that nothing was selected in
order to have the button click check for all possible updates.  

Marcia:  Are you sure you don't have a single ext. selected when you click the
button?  Just wanted to make sure.  The selection behavior might be different on
Mac, but for me, the first item in the ext. manager is always selected...so
simple opening the manager and clicking update only checks for updates for that
first ext.

Comment 5

[Gary Elshaw]

I can't reproduce here: tried old version of gmail notifier on mac 105 candidate
and manager finds update.

Comment 6

[Zach Lipton [:zach]]

After some headscratching, I figured out what you have to do to reproduce this. 

1. Install an old extension (I used Add Bookmark Here 0.5.3)
2. Restart
3. Tools->Extensions
4. (the key step) click in the extensions window so that no extension is
selected (e.g. nothing should be highlighted).
5. Click the check for update button. 

What should happen is that we check for updates to all extensions. Instead, we
seemingly check for updates to no extensions. 

Comment 7

[Marcia Knous [:marcia]]

Jay: we should get a bug on file for the highlighting issue, especially if it
happens on windows. It shouldn't matter whether you have anything highlighted.
we should make sure that this works for the 1.1 release as well.

(In reply to comment #4)
> For the record, this is not a problem on Windows.  I was able to check for
> updates  without issue in the extension manager with Mozilla/5.0 (Windows; U;
> Windows NT 5.1; en-US; rv:1.7.9) Gecko/20050707 Firefox/1.0.5.
> 
> However, I noticed that sometimes a single extension is selected and if you
> click the update button, it will only check for that particular extensions.  I
> had to ctrl-click on the highlighted extension so that nothing was selected in
> order to have the button click check for all possible updates.  
> 
> Marcia:  Are you sure you don't have a single ext. selected when you click the
> button?  Just wanted to make sure.  The selection behavior might be different on
> Mac, but for me, the first item in the ext. manager is always selected...so
> simple opening the manager and clicking update only checks for updates for that
> first ext.

Comment 8

[Robert Strong (they/them - no direct email)]

For the trunk this has been fixed by bug 300116.

Comment 9

[Robert Strong (they/them - no direct email)]

Resolving -> WFM. Fixed by bug 300116.