Closed Bug 300039 Opened 19 years ago Closed 19 years ago

Firefox crashes if you cancel a download, retry it and then cancel that download too

Categories

(Toolkit :: Downloads API, defect)

x86
Windows XP
defect
Not set
critical

Tracking

()

VERIFIED FIXED

People

(Reporter: wgianopoulos, Assigned: mconnor)

Details

Attachments

(1 file)

If you download a file using firefox and then cancel the download via the
download manager and then subsequently click the retry link in the download
manager and then cancel a second time, Firefox crashes dereferencing a null pointer.
Attachment #188621 - Flags: review?(benjamin)
Attachment #188621 - Flags: approval-aviary1.1a2?
Comment on attachment 188621 [details] [diff] [review]
nullchecking is good

r=bsmedberg. Please check with Chase about the status of respins and such for
approval, but I think this is 1.1a2-worthy.
Attachment #188621 - Flags: review?(benjamin) → review+
Looks like respins are happening so noinating this simple crash fix to get it on
the radar
Flags: blocking1.8b3?
Comment on attachment 188621 [details] [diff] [review]
nullchecking is good

a=chase.  Land asap to catch a ride on 1.1a2.
Attachment #188621 - Flags: approval-aviary1.1a2? → approval-aviary1.1a2+
Fixed on trunk for respins.
Status: NEW → RESOLVED
Closed: 19 years ago
Flags: blocking1.8b3?
Resolution: --- → FIXED
Verified FIXED; haven't seen this in my DM testing on trunk.
Status: RESOLVED → VERIFIED
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: