300040 - download manager cleanup button ("X") is confusing

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect)

Description

[Josh Aas]

The square button with the "X" on it in the Mac OS X download manager is really
confusing. The UI gives little indication of what the button does. Does it
delete files? Cancel downloads? Just remove them from the UI? On Windows, the
button says something like "Clean up", which is better.

We need to replace that UI. Maybe we should just do what Windows does, maybe
something else...

I think this is a serious problem, and should block Firefox 1.1.

Comment 1

[philippe (part-time)]

"Clear" ? (as in Safari).

Comment 2

[philippe (part-time)]

Attachment: screenshot with 'Clear'

Quick and dirty job, I think it should be a bit wider

Comment 3

[Asaf Romano (gone)]

Theme issue -> Kevin. (We also have a bug on the extenstion manager, somewhere)

Comment 4

[Mike Connor [:mconnor]]

We use Clean Up as text, which requires no l10n, just skinning changes.  not an
actual blocker, b4 or it slips.

Comment 5

[Josh Aas]

Agreed about this bug not being a release blocker, but I want to say that I do
think this is a very serious bug. It makes the UI element almost useless to the
inexperienced, and I even get confused about it. I use it about once a month and
I have to wait and reconsider what it does every time.

I am marking this as serious because I consider it to be a top priority for UI
fixes in Deer Park.

Comment 6

[Kevin Gerich]

Attachment: Cleaned up download window

Fix is in patch attached to bug 281974

Comment 7

[Kevin Gerich]

fixed on branch and trunk by patch from bug 281974