300074 - Disable actions when no items are selected in the Download Actions/Cookie Manager dialogs

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Caleb]

Here's how to reproduce:

1. Tools > Options > Downloads > View & Edit Actions
2. Write something in the search field so no results are returned
3. Double click the empty treeview

An empty Change Action dialog will pop up.

Comment 1

[Mike Pesce (:By-Tor)]

Confirmed with DPA2: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b3)
Gecko/20050707 Firefox/1.0+ ID:2005070719

Comment 2

[Caleb]

This seems to affect people who have a populated actions list.
Also, instead of double clicking you can also press the Change Action button.

http://lxr.mozilla.org/seamonkey/source/browser/components/preferences/downloadactions.js#616

616   editFileHandler: function ()
617   {
618     var selection = this._tree.view.selection; 
619     if (selection.count != 1)
620       return;

It seems that a check is in-place for this... but selection.count IS equal to 1,
 so I'm not really sure where this problem stems from.

Comment 3

[Caleb]

Attachment: patch v1.0

This seems to take care of it.

We reset the selection if there are no items in view (instead of selecting a
magical-non existant 0 index), and if there are items then we just select the
first one (just like before).

Comment 4

[Caleb]

Attachment: patch v1.1

Well, the previous patch seems to erase the selection that was made prior to
the current filter and this one should take care of it. (thx Mano)

Comment 5

[Caleb]

Attachment: patch v1.2

This is supposed to be the final revision.

It:
 * Makes sure that the "Change Action" button is also disabled when there are
no items in view
 * "Remove Cookie" button is disabled when there are no items in view

Comment 6

[Asaf Romano (gone)]

Comment on attachment 188683 [details] [diff] [review]
patch v1.2


>+      if (view.rowCount > 0)
>+        view.selection.select(0);
>+

you have already returned out in the rowCount == 0 case.

Comment 7

[Asaf Romano (gone)]

Comment on attachment 188683 [details] [diff] [review]
patch v1.2

ignore the last comment, i read it wrong.

Comment 8

[Caleb]

Comment on attachment 188683 [details] [diff] [review]
patch v1.2

Optimistically requesting approval for an itsy bitsy UI regression.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

See bug 300001 for existing js warnings and errors.

Comment 10

[Caleb]

Comment on attachment 188683 [details] [diff] [review]
patch v1.2

I'll re-request approval once we're done with 1.1a2.

Comment 11

[Asaf Romano (gone)]

Checking in cookies.js;
/cvsroot/mozilla/browser/components/preferences/cookies.js,v  <--  cookies.js
new revision: 1.8; previous revision: 1.7
done
Checking in downloadactions.js;
/cvsroot/mozilla/browser/components/preferences/downloadactions.js,v  <-- 
downloadactions.js
new revision: 1.4; previous revision: 1.3
done

Comment 12

[PikeUK]

*** Bug 284094 has been marked as a duplicate of this bug. ***

Comment 13

[:Gavin Sharp [email: [e-mail]]]

*** Bug 297617 has been marked as a duplicate of this bug. ***