Closed
Bug 300105
Opened 19 years ago
Closed 19 years ago
The found link doesn't have pseudo-focus in FAYT on frame page
Categories
(Core :: DOM: UI Events & Focus Handling, defect, P2)
Core
DOM: UI Events & Focus Handling
Tracking
()
RESOLVED
FIXED
mozilla1.8beta4
People
(Reporter: masayuki, Assigned: masayuki)
References
()
Details
Attachments
(1 file, 2 obsolete files)
1.27 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
asa
:
approval1.8b4+
|
Details | Diff | Splinter Review |
1. See http://bugzilla.mozilla.gr.jp/attachment.cgi?id=2850&action=view 2. Type "'" 3. Type"f" In this case, FAYT found the link in inner frame. But the found link didn't have the pseudo-focus. If after to click the document, FAYT set the pseudo-focus to the found link.
Assignee | ||
Updated•19 years ago
|
Assignee: nobody → masayuki
Assignee | ||
Updated•19 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P2
Target Milestone: --- → Firefox1.1
Updated•19 years ago
|
Flags: blocking1.8b4?
Flags: blocking-aviary1.1?
Assignee | ||
Comment 1•19 years ago
|
||
Attachment #188764 -
Flags: superreview?(bzbarsky)
Attachment #188764 -
Flags: review?(bzbarsky)
Comment 2•19 years ago
|
||
Is there ever a case when the mPresContext will be null? Also, if this is a Core bug (which it is), please move it to Core.
Assignee | ||
Comment 3•19 years ago
|
||
> Is there ever a case when the mPresContext will be null?
I don't know. It's safety code.
Should I remove it?
Component: Find Toolbar / FastFind → Event Handling
Flags: review?(bzbarsky)
Product: Firefox → Core
Target Milestone: Firefox1.1 → ---
Assignee | ||
Updated•19 years ago
|
Attachment #188764 -
Flags: review?(jst)
Comment 4•19 years ago
|
||
If you're not hitting cases when it's null, then yes. I don't see how such cases could reasonably arise.
Assignee | ||
Updated•19 years ago
|
Attachment #188764 -
Flags: superreview?(bzbarsky)
Attachment #188764 -
Flags: review?(jst)
Attachment #188764 -
Flags: review-
Assignee | ||
Comment 5•19 years ago
|
||
O.K. I cannot find mPresContext is null in my test.
Attachment #188764 -
Attachment is obsolete: true
Attachment #188856 -
Flags: superreview?(bzbarsky)
Attachment #188856 -
Flags: review?(jst)
Assignee | ||
Updated•19 years ago
|
Attachment #188856 -
Flags: superreview?(bzbarsky)
Attachment #188856 -
Flags: review?(jst)
Attachment #188856 -
Flags: review-
Assignee | ||
Comment 6•19 years ago
|
||
Attachment #188856 -
Attachment is obsolete: true
Attachment #188857 -
Flags: superreview?(bzbarsky)
Attachment #188857 -
Flags: review?(jst)
Updated•19 years ago
|
Attachment #188857 -
Flags: superreview?(bzbarsky)
Attachment #188857 -
Flags: superreview+
Attachment #188857 -
Flags: review?(jst)
Attachment #188857 -
Flags: review+
Assignee | ||
Comment 7•19 years ago
|
||
Comment on attachment 188857 [details] [diff] [review] Patch rv1.2 The risk is low. I think it is important bug for FAYT.
Attachment #188857 -
Flags: approval1.8b3?
Updated•19 years ago
|
Flags: blocking1.8b4?
Flags: blocking-aviary1.1?
Updated•19 years ago
|
Attachment #188857 -
Flags: approval1.8b3? → approval1.8b4+
Assignee | ||
Comment 8•19 years ago
|
||
checked-in.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•19 years ago
|
Target Milestone: --- → mozilla1.8beta4
Comment 9•19 years ago
|
||
Thank you! Working well here.
Updated•5 years ago
|
Component: Event Handling → User events and focus handling
You need to log in
before you can comment on or make changes to this bug.
Description
•