Closed Bug 300129 Opened 19 years ago Closed 19 years ago

GTK1 builds don't have a default icon

Categories

(Core Graveyard :: GFX: Gtk, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: neil, Assigned: neil)

References

Details

Attachments

(1 file)

Although GTK2 builds will give windows a default icon based on
chrome/icons/default.xpm GTK1 builds have no default icon support.
Attached patch Proposed patchSplinter Review
Assignee: blizzard → neil.parkwaycc.co.uk
Status: NEW → ASSIGNED
Attachment #188704 - Flags: superreview?(roc)
Attachment #188704 - Flags: review?(akkzilla)
Attachment #188704 - Flags: superreview?(roc)
Attachment #188704 - Flags: superreview+
Attachment #188704 - Flags: review?(akkzilla)
Attachment #188704 - Flags: review+
Comment on attachment 188704 [details] [diff] [review]
Proposed patch

Trivial fix, non-Firefox code.
Attachment #188704 - Flags: approval1.8b3?
Attachment #188704 - Flags: approval1.8b4?
Attachment #188704 - Flags: approval1.8b4?
Attachment #188704 - Flags: approval1.8b4+
Attachment #188704 - Flags: approval1.8b3?
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Is bug 242598 dupe of this?
*** Bug 242598 has been marked as a duplicate of this bug. ***
*** Bug 265077 has been marked as a duplicate of this bug. ***
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: