300144 - mailnews.message_display.allow.plugins pref not followed

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Suite has UI for the mailnews.message_display.allow.plugins pref, but the back
end never checks it (compare to nsMsgContentPolicy.cpp, which does).  This
should be fixed....

Comment 1

[Boris Zbarsky [:bzbarsky]]

Actually, it's "followed" in that we don't create layout objects (but content
policy doesn't block them, so we may still load the data once biesi moves plugin
loading to content).  On branch this is a non-issue, but on trunk we want to fix
this, I think.

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

FWIW, the current version of my patch only loads plugins if a frame exists. but
yeah, the intent is to change that at some point.

Comment 3

[[e-mail]]

So do we need to start using content policy?

Comment 4

[Boris Zbarsky [:bzbarsky]]

It's a matter of what the "allow plugins" pref should mean.  Should it mean no
loading of the data?  Or should it mean no instantiating a plugin?

Comment 5

[Ian Neal]

I would say this is fixed (or WFM) as Suite started using nsMsgContentPolicy.cpp back in 2006. Removing blocking request.

Comment 6

[Boris Zbarsky [:bzbarsky]]

If we're using nsMsgContentPolicy, great.