Closed Bug 300197 Opened 19 years ago Closed 19 years ago

Should set focus to found link in Normal Find(Ctrl + F)

Categories

(Toolkit :: Find Toolbar, enhancement, P3)

Product:
Toolkit
Component:
Find Toolbar
Type:
enhancement

Tracking

()

Status:
VERIFIED DUPLICATE of bug 296720
Milestone:
mozilla1.8final

People

(Reporter: masayuki, Assigned: masayuki)

Details

Attachments

(2 files, 1 obsolete file)

Patch TypeA rv1.0
3.65 KB, patch
mconnor
: review-
Details | Diff | Splinter Review
Patch TypeB rv1.1
3.89 KB, patch
mconnor
: review-
Details | Diff | Splinter Review 
In FAYT's text find mode("/") and Normal Find(Ctrl + F), should we set focus to
found link? Currently, we set focus to found link only in FAYT's link find
mode("'").

By bug 259454 is fixed, we get new behavior, that is pseudo-focus.
We can set pseudo-focus to found link, even if the "real" focus is set to find
toolbar. So now, we can set focus to found link in *all find mode*.
Priority: -- → P3
Summary: Should we set focus to found link in FAYT(text mode) and Normal Find(Ctrl + F)? → Should we set focus to found link in Normal Find(Ctrl + F)?

  

  



        Attachment #188774 -
        Flags: review?(mconnor)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch TypeB rv1.0 (obsolete)
        — 
          — Splinter Review
      

    


  
Patch TypeA is changing the handling of Enter key in Ctrl + F.
Ctrl + F (When it did not find link)
  Enter, Ctrl + Enter and Shift + Enter are "find next", "Hilight keyword" and 

  "find previous".
Ctrl + F (When it found link)
  Enter and any key + Enter fire same key event on found link element.
  I.e, Enter is "open the link", Ctrl + link is "open the link in new tab"...

Patch TypeB is not changing the handling.
So, we can control the link with Enter key when FAYT mode only. When Ctrl + F
mode, we cannot control the link element by Enter key.

Please select better behavior.

  

  



        Attachment #188775 -
        Flags: review?(mconnor)
Status: NEW → ASSIGNED
Flags: blocking-aviary1.1?
Target Milestone: --- → Firefox1.1

        Attachment #188775 -
        Flags: review?(mconnor) → review-

    
    

    
  


  

  

  



        Attachment #188775 -
        Attachment is obsolete: true

        Attachment #188776 -
        Flags: review?(mconnor)
Summary: Should we set focus to found link in Normal Find(Ctrl + F)? → Should we set focus to found link in Normal Find(Ctrl + F)
Summary: Should we set focus to found link in Normal Find(Ctrl + F) → Should set focus to found link in Normal Find(Ctrl + F)

        Attachment #188774 -
        Flags: review?(mconnor) → review-

        Attachment #188776 -
        Flags: review?(mconnor) → review-

    
    

    
  
I don't see an issue with the current behaviour that requires any changes.  See
bug 296720 for the extensive debate.

*** This bug has been marked as a duplicate of 296720 ***

  

  


Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → DUPLICATE

    
  
Status: RESOLVED → VERIFIED
Flags: blocking-aviary1.1?
Product: Firefox → Toolkit

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: