Closed Bug 300217 Opened 19 years ago Closed 19 years ago

one day allday event shows on two days

Categories

(Calendar :: Sunbird Only, defect)

Product:
Calendar
Component:
Sunbird Only
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mvl, Assigned: mvl)

Details

Attachments

(1 file)

patch v1
1.62 KB, patch
jminta
: first-review+
Details | Diff | Splinter Review 
the enddate is exclusive. We need to not show the last day. (The problem is
really in the disaply, as the ics file is correct)
Attached patch patch v1 — — Splinter Review 

  

  



        Attachment #188787 -
        Flags: first-review?(jminta)

    
    

    
  
Comment on attachment 188787 [details] [diff] [review]
patch v1

Are you sure this should be fixed in calendarWindow?  It seems to me that
createEventBox never should have even gotten the occurrence from
ccalendar.getItems.

Also, you've got a random extra newline.

  

  



    
    

    
  
It gets only one occurence, which lasts a one day. The end date is the next day,
because it is exclusive. When splitting into days, it should skip that last day.

  

  



    
    

    
  
Comment on attachment 188787 [details] [diff] [review]
patch v1

r+ without the newline

  

  



        Attachment #188787 -
        Flags: first-review?(jminta) → first-review+

    
    

    
  
I think we're done with this.  Checkin at 2005-07-10 12:02.

  

  


Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: