300221 - xul error on "About Thunderbird"

Status: VERIFIED FIXED

(Thunderbird :: General, defect)

Description

[baffclan]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b3) Gecko/20050709 SeaMonkey/1.0a
Build Identifier: version 1.0+ (20050709)

xul error on "About Thunderbird"

    <h2 class="title">&brandFullName;&traide;
---------------------------^


Reproducible: Always

Steps to Reproduce:
1. run Thunderbird
2. open "About Thunderbird"
   Help -> About Mozilla Thunderbird Alpha 2
3. click "Credits"

Actual Results:  
error shows in "About Thunderbird" window

Expected Results:  
displayed "Credits"

version 1.0+ (20050703) build have not this problem

Comment 1

[Marcia Knous [:marcia]]

While I am testing Mac on the branch, I am not seeing the error, but the credits
don't display.

Can someone on Windows confirm this on the trunk?

Comment 2

[Carsten Book [:Tomcat]]

Confirmed version 1.0+ (20050709)

Error: undefined entity
Source File: 
jar:file:///C:/PROGRA~1/MOZILL~1/chrome/messenger.jar!/content/messenger/credits
.xhtml
Line: 163, Column: 42
Source Code:
        <h2 class="title">&brandFullName;&trade;

Comment 3

[Scott MacGregor]

this is fall out from moving to credits.xhtml a couple days ago I think. I've
been trying to track it down for a couple days now. 

Comment 4

[diorser]

Still confirmed with version 1.0+ [1.8b3: 2005.07.10.06 - windows]

Comment 5

[diorser]

Still confirmed with version 1.0+ [1.8b3: 2005.07.11.04 - windows]

Comment 6

[Scott MacGregor]

dioser: please don't do that. It is not helpful to confirm an open bug every day
we have a nightly build that doesn't have a fix yet. If this bug gets marked as
fixed and the next day you still have the problem, then feel free to comment.
Thanks.

Comment 7

[Scott MacGregor]

Marcia, I don't see this xul entity error on the latest Thunderbird 1.0.5 build
at all (for Windows).

Which is a good thing because the credits.xhtml file change never happened on
the branch and I would be really worried it it did show the entity error :)

Comment 8

[Marcia Knous [:marcia]]

Scott; I don't think we were seeing the XUL error during our 1.0.5 testing, but
I did note during Mac testing that the "About Thunderbird" credits was not
working. If you click on the credits button nothing happens.  During the Linux
1.0.5 BFT today I am seeing the same thing.

Comment 9

[Scott MacGregor]

Attachment: the fix

this took me a long time to find because I kept thinking the credits file was
getting the trademark entity from html40symbols.properties and didn't notice it
was contained in xhtml11.dtd.

Comment 10

[Zach Lipton [:zach]]

The credits button works for me on the mac 105 branch candidate, so we should be
ok. 

Comment 11

[Marcia Knous [:marcia]]

Confirming what Zach says, this does work in 1.0.5 on Linux and Mac. Sorry for
the noise.

Comment 12

[Carsten Book [:Tomcat]]

v. with latest tinderbox build.

Comment 13

[Onno Witvliet]

I still get the error with both the zip and the installer versions:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b3) Gecko/20050712
Thunderbird/1.0+ ID:2005071208

Comment 14

[Alex Ihrig [:Thunderbird_Mail_DE]]

The XUL-Error ist still existing in Thunderbird Version 1.0+ (20050711)!

AFAIK the mac builds never had this error, so we should have an eye on win /
linux builds!

Comment 15

[Scott MacGregor]

Attachment: the right fix

How about using the right path for the string file. shame on me

Comment 16

[Scott MacGregor]

fix checked in now that the tree is open for beta work.

Comment 17

[baffclan]

verified with Thunderbird/2005071407-trunk/WinXP

thanks!