300254 - Can't edit a calendar

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Joey Minta]

We have a lovely editCalendar dialog, but no way to get to it. Doubleclicking 
on a calendar in the listbox does nothing, and choosing edit-calendar from the 
context menu throws:
Error: gCalendarWindow.calendarManager.launchEditCalendarDialog is not a 
function
Source File: chrome://calendar/content/calendar.xul
Line: 1

Comment 1

[Michiel van Leeuwen (email: mvl+moz@)]

Works for me in calendar-in-seamonkey. Sounds some patch needs to be ported to
sunbirds calendar.xul

Comment 2

[Joey Minta]

(In reply to comment #1)
> Works for me in calendar-in-seamonkey. Sounds some patch needs to be ported to
> sunbirds calendar.xul


Does double-clicking on a calendar work for you in seamonkey?  I can't find an 
ondblclick attribute anywhere.

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

No, doubleclick doesn't work. context menu->edit calendar does.

Comment 4

[Joey Minta]

Attachment: patch v1

Moves sunbird to using the new commands.  Also fixes the calendar listbox popup
to disable certain options if it isn't clicked on an actual calendar. 
(Otherwise, choosing them results in a js error.)

Comment 5

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 189202 [details] [diff] [review]
patch v1

looks good. r=mvl (but we really need to think more about sharing one
calendar.xul)

Comment 6

[Michiel van Leeuwen (email: mvl+moz@)]

patch checked in