300292 - rewrite nsMacShellService::SetDesktopBackground

Status: RESOLVED FIXED

(Firefox :: Shell Integration, defect, P2)

Description

[Asaf Romano (gone)]

The current implementation of |nsMacShellService::SetDesktopBackground| has some
errors:

1) It crashes for non-URL image sources (i.e. the data: protocol.
2) We're getting the URL from the source attribute instead of poking
nsIImageLoadingContent::GetCurrentURI
3) In the case where the images base uri is different from the document uri,
we're passing the wrong referer to nsIWebBrowserPersist::saveURI
4) We might return the wrong nsresult values, in failures.

The attached patch fixes issues 2, 3 and 4 and partly fixes the first issue,
that is: we don't crash anymore, but we still don't actually support data: uris,
since i'm not sure what can we do about their filenames.

Comment 1

[Asaf Romano (gone)]

filed bug 300293 on supporting data: images.

Comment 2

[Asaf Romano (gone)]

Attachment: patch

too bad i can't ask for more than one review flag in the Firefox
bugzilla-product.

Comment 3

[Mike Connor [:mconnor]]

Comment on attachment 188872 [details] [diff] [review]
patch

r=me

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

   nsCOMPtr<nsIDOMHTMLImageElement> image(do_QueryInterface(aElement));
   if (!image)
     return NS_ERROR_INVALID_ARG;
 
do you still need that?

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 188872 [details] [diff] [review]
patch

also:
   nsCOMPtr<nsIDOM3Node> node(do_QueryInterface(aElement));
+  nsCOMPtr<nsIContent> content = do_QueryInterface(node, &rv);

why not directly qi to nsIContent?

Comment 6

[Asaf Romano (gone)]

Attachment: patch

good points, biese.

Comment 7

[Mike Connor [:mconnor]]

Comment on attachment 189211 [details] [diff] [review]
patch

r=me on the changes, carrying over a=

Comment 8

[Asaf Romano (gone)]

Checking in src/nsMacShellService.cpp;
/cvsroot/mozilla/browser/components/shell/src/nsMacShellService.cpp,v  <-- 
nsMacShellService.cpp
new revision: 1.7; previous revision: 1.6
done