300312 - Template field is empty for filters on local folders

Status: RESOLVED FIXED

(MailNews Core :: Filters, defect)

Description

[Ian Neal]

Using TB build ID 20050705 and SM build ID 2005070506 on Win XP SP2
Steps to reproduce
1. Make sure your have a template in the local folders' templates folder
1. Create a new filter for local folders
2. Click on the reply with template dropdown

Expected result
1. List of available templates from local folders' templates folder

Actual result
1. Empty list

It looks like
accountManager.getFirstIdentityForServer(gFilterList.folder.server) returns null
for local folders as the server, which I think is what causes the problem.
We either need to disable reply with template for local folders or get the
correct resource for the local folders' template folder.

Comment 1

[David :Bienvenu]

Attachment: fix general case (but not specific local folders case)

this was fallout from bug 297360 - I'd like to fix this for 1.1a2, even if your
rewrite fixes this in general, Scott.

Comment 2

[David :Bienvenu]

Comment on attachment 188946 [details] [diff] [review]
fix general case (but not specific local folders case)

this is needed for new reply with template feature to work.

Comment 3

[David :Bienvenu]

fix for general case is checked in; I'll look at the specific local folders case
later.

Comment 4

[Ian Neal]

*** Bug 300384 has been marked as a duplicate of this bug. ***

Comment 5

[RenegadeX]

(In reply to comment #3)
> fix for general case is checked in; I'll look at the specific local folders
> case later.

I experienced this Bug on TB 1.5RC2 - I posted my findings (including screenshot) on Mozillazine:
http://forums.mozillazine.org/viewtopic.php?t=363805&highlight=

The strange thing is that it 'fixed' itself... though I have no idea how/why.

Comment 6

[Wayne Mery (:wsmwk)]

Bienvenu still want this assigned?

Comment 7

[Kent James (:rkent)]

Since in TB 3.1 I made local folders the default for deferred accounts, this is going to show up more. I'm assigning to myself to keep it on my radar screen, but no promises of when I will get to it.

Comment 8

[Kent James (:rkent)]

Attachment: Use defaultAccount.defaultIdentity for Local Folders

Error console shows identity is null when you try to select a template for a Local Folder. There is no perfect choice for identify, but defaultAccount.defaultIdentity should work just fine for most users.

Comment 9

[David :Bienvenu]

Comment on attachment 528529 [details] [diff] [review]
Use defaultAccount.defaultIdentity for Local Folders

I had to restart after creating the local folders templates folder for the first time, but after that it worked - I guess computers hate me too!

Comment 10

[Kent James (:rkent)]

Comment on attachment 528529 [details] [diff] [review]
Use defaultAccount.defaultIdentity for Local Folders

Checked in http://hg.mozilla.org/comm-central/rev/74b6bb752d8e

Comment 11

[Philip Chee]

Just a SeaMonkey FYI. Pushed to comm-2.0
http://hg.mozilla.org/releases/comm-2.0/rev/193447332537