300336 - Bugzilla::Auth should not contain any exported subroutines

Status: RESOLVED FIXED

(Bugzilla :: User Accounts, defect, P2)

Description

[Max Kanat-Alexander]

Bugzilla::Auth does really funky stuff in its BEGIN block that messes up the
perl compiler in all sorts of situations if you "use Bugzilla::Auth."

So, we should never put ourselves in a situation where we have to "use
Bugzilla::Auth." Basically, that means we should remove bz_crypt from
Bugzilla::Auth, and probably put it in Bugzilla::Util.

Comment 1

[Max Kanat-Alexander]

Attachment: v1

OK, I'm moving the bz_crypt function out, and I also messed with some comments
in checksetup a bit while I was there, to make them a bit more clear (and to
fix them for the changes in this bug).

runtests passes with this patch. It's a very straightforward patch; just a code
move.

Comment 2

[Frédéric Buclin]

yeah.. Bugzilla::Util is definitely the right place for bz_crypt. :)

Comment 3

[Max Kanat-Alexander]

OK, actually, this also affects 2.20rc1.

Comment 4

[Frédéric Buclin]

Comment on attachment 188910 [details] [diff] [review]
v1

>+eval("use Bugzilla:Util");

Nit: what about: eval("use Bugzilla:Util qw(bz_crypt)"); ? If you agree to
import bz_crypt only, I would be very happy. If you don't, nevermind.

Tested on both the trunk and 2.20. r=LpSolit

Comment 5

[Max Kanat-Alexander]

*** Bug 300219 has been marked as a duplicate of this bug. ***

Comment 6

[Max Kanat-Alexander]

Tip:

Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.417; previous revision: 1.416
done
Checking in editusers.cgi;
/cvsroot/mozilla/webtools/bugzilla/editusers.cgi,v  <--  editusers.cgi
new revision: 1.91; previous revision: 1.90
done
Checking in globals.pl;
/cvsroot/mozilla/webtools/bugzilla/globals.pl,v  <--  globals.pl
new revision: 1.328; previous revision: 1.327
done
Checking in token.cgi;
/cvsroot/mozilla/webtools/bugzilla/token.cgi,v  <--  token.cgi
new revision: 1.32; previous revision: 1.31
done
Checking in userprefs.cgi;
/cvsroot/mozilla/webtools/bugzilla/userprefs.cgi,v  <--  userprefs.cgi
new revision: 1.76; previous revision: 1.75
done
Checking in Bugzilla/Auth.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Auth.pm,v  <--  Auth.pm
new revision: 1.11; previous revision: 1.10
done
Checking in Bugzilla/User.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/User.pm,v  <--  User.pm
new revision: 1.63; previous revision: 1.62
done
Checking in Bugzilla/Util.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Util.pm,v  <--  Util.pm
new revision: 1.29; previous revision: 1.28
done
Checking in Bugzilla/Auth/Verify/DB.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Auth/Verify/DB.pm,v  <--  DB.pm
new revision: 1.6; previous revision: 1.5
done

2.20:

Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.412.2.2; previous revision: 1.412.2.1
done
Checking in editusers.cgi;
/cvsroot/mozilla/webtools/bugzilla/editusers.cgi,v  <--  editusers.cgi
new revision: 1.90.2.1; previous revision: 1.90
done
Checking in globals.pl;
/cvsroot/mozilla/webtools/bugzilla/globals.pl,v  <--  globals.pl
new revision: 1.326.2.2; previous revision: 1.326.2.1
done
Checking in token.cgi;
/cvsroot/mozilla/webtools/bugzilla/token.cgi,v  <--  token.cgi
new revision: 1.31.2.1; previous revision: 1.31
done
Checking in userprefs.cgi;
/cvsroot/mozilla/webtools/bugzilla/userprefs.cgi,v  <--  userprefs.cgi
new revision: 1.75.4.1; previous revision: 1.75
done
Checking in Bugzilla/Auth.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Auth.pm,v  <--  Auth.pm
new revision: 1.10.2.1; previous revision: 1.10
done
Checking in Bugzilla/User.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/User.pm,v  <--  User.pm
new revision: 1.61.2.2; previous revision: 1.61.2.1
done
Checking in Bugzilla/Util.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Util.pm,v  <--  Util.pm
new revision: 1.28.2.1; previous revision: 1.28
done
Checking in Bugzilla/Auth/Verify/DB.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Auth/Verify/DB.pm,v  <--  DB.pm
new revision: 1.5.2.1; previous revision: 1.5
done

Comment 7

[Frédéric Buclin]

*** Bug 295258 has been marked as a duplicate of this bug. ***

Comment 8

[Frédéric Buclin]

*** Bug 300859 has been marked as a duplicate of this bug. ***