300356 - Extension/Theme Manager windows default size should be editable by l10n-teams

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Alex Ihrig [:Thunderbird_Mail_DE]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de-DE; rv:1.7.8) Gecko/20050511 Firefox/1.0.4
Build Identifier: Trunkbuilds 20050710

The Extension/Theme Managers windows have a fixed default size and they are to
small for many l10n builds. Okay, they are resizeable by the user. So it is no
major problem, if not the whole window content is shown, when opening these
windows the first time. 

It would be much nicer, if l10n-teams would be able to set an (other) default
size for these windows.

Reproducible: Always

Actual Results:  
Windows are to small, when opening the first time. So not all the content / GUI
is visible.

Expected Results:  
The windows sizes should be adjustable by the l10n teams, so the windows would
have the correct size and show the full content, when they are opened the first
time by users.

We could use entities for "width:XXem; height:XXem" in locale files.

Comment 1

[Alex Ihrig [:Thunderbird_Mail_DE]]

Attachment: Patch for toolkit/mozapps/extensions/extensions.dtd

There is one more file for this patch (the locale file).

Comment 2

[Alex Ihrig [:Thunderbird_Mail_DE]]

Attachment: Patch for toolkit/mozapps/extensions/extensions.xul

This is the XUL file, which refers to the other (locale) file.

Comment 3

[Alex Ihrig [:Thunderbird_Mail_DE]]

Comment on attachment 188931 [details] [diff] [review]
Patch for toolkit/mozapps/extensions/extensions.dtd

Maybe for en-US build we should reduce the width. 575px are necessary for
german de builds.

Comment 4

[Robert Kaiser]

I'd the "width:XXem; height:XXem" variant more (but it's just me), for which
you'd need to specify that in style (CSS), not as a normal XUL attribute.
I'd expect most of the other dialogs with localizeable size to have it that way,
e.g. the SeaMonkey pref window... You can look at those to see how that is done.

Comment 5

[Benjamin Smedberg]

The problem is that the theme manager and the extension manager should be
different sizes: see
http://lxr.mozilla.org/mozilla/source/toolkit/mozapps/extensions/content/extensions.js#219

You're probably going to need a stringbundle to deal with the dynamic-sizing code.

Comment 6

[Alex Ihrig [:Thunderbird_Mail_DE]]

Attachment: Add a new entity in the locale file 'extensions.dtd' and refer to this entity in 'extensions.xul'

Includes both previous patch files in one file.

Comment 7

[Alex Ihrig [:Thunderbird_Mail_DE]]

I've been trying to use style (with em sizes) instead of the pixel sizes, but
I'm not yet able to get it working.

It would be a good idea to have separated sizes for Themes / Extensions Manager.

I'll change the patch, to use extensions.properties in extensions.js.

Comment 8

[Benjamin Smedberg]

I much prefer using width="" height="" than to use style="" because the
interactions with xul:persist are simpler and more obvious. KaiRo, I'm not sure
why you prefer the style="" version but I do not for toolkit files.

Comment 9

[Alex Ihrig [:Thunderbird_Mail_DE]]

Attachment: Add a new entities in the locale file 'extensions.properties' and refer to this entity in 'extensions.js'

This new Patch v3 gives us the possibility to have different default sizes for
themes / extensions manager windows. The patch still uses pixel sizes (the same
way as it was original extensions.js) instead of style attributes with em
sizes.

Comment 10

[Alex Ihrig [:Thunderbird_Mail_DE]]

Attachment: Add new entities in the locale file 'extensions.properties' and refer to this entity in 'extensions.js'

Changed the default sizes to the original en-US ones.

Do we have a chance to get this in 1.1 final?

Comment 11

[Robert Strong (they/them - no direct email)]

This would also be a good time to set the width of the left panel in the same
manner for the theme manager as is done in js via style here
http://lxr.mozilla.org/mozilla/source/toolkit/mozapps/extensions/content/extensions.js#214

Comment 12

[Alex Ihrig [:Thunderbird_Mail_DE]]

Attachment: Patch v5

Added the possibility to adjust the left column in themes manager window.

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Patch checked in by timeless.