Closed Bug 300379 Opened 20 years ago Closed 20 years ago

GenerateVersionTable's rename may fail silently

Categories

(Bugzilla :: Bugzilla-General, defect)

2.18
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 2.20

People

(Reporter: glob, Assigned: glob)

Details

Attachments

(1 file)

GenerateVersionTable's rename may fail silently as it has: rename $tmpname, "$datadir/versioncache" || die "Can't rename $tmpname to versioncache"; it should be: rename ($tmpname, "$datadir/versioncache") || die "Can't rename $tmpname to versioncache";
Attached patch v1Splinter Review
Assignee: general → bugzilla
Status: NEW → ASSIGNED
Attachment #188948 - Flags: review?
Comment on attachment 188948 [details] [diff] [review] v1 r=LpSolit
Attachment #188948 - Flags: review? → review+
Flags: approval?
Flags: approval2.20?
Target Milestone: --- → Bugzilla 2.20
Flags: approval?
Flags: approval2.20?
Flags: approval2.20+
Flags: approval+
2.21: Checking in globals.pl; /cvsroot/mozilla/webtools/bugzilla/globals.pl,v <-- globals.pl new revision: 1.327; previous revision: 1.326 done 2.20rc1: Checking in globals.pl; /cvsroot/mozilla/webtools/bugzilla/globals.pl,v <-- globals.pl new revision: 1.326.2.1; previous revision: 1.326 done
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: